From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC1D2A04C8; Fri, 15 Nov 2019 05:14:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F02C02F42; Fri, 15 Nov 2019 05:14:46 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 262F12C12; Fri, 15 Nov 2019 05:14:44 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2019 20:14:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,307,1569308400"; d="scan'208";a="379814520" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by orsmga005.jf.intel.com with ESMTP; 14 Nov 2019 20:14:42 -0800 Date: Fri, 15 Nov 2019 12:15:20 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: Zhike Wang , dev@dpdk.org, stable@dpdk.org, security@dpdk.org, wangzhike@jd.com Message-ID: <20191115041520.GA22736@___> References: <1573643008-8216-1-git-send-email-wangzk320@163.com> <36d4ff71-bce4-6b69-7110-c4f6b9bfa51d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <36d4ff71-bce4-6b69-7110-c4f6b9bfa51d@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: fix vring message handling broken in some case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 14, 2019 at 09:52:30AM +0100, Maxime Coquelin wrote: > Maybe change the title to something like: > > vhost: fix vring requests validation broken if no FD in payload > > On 11/13/19 12:03 PM, Zhike Wang wrote: > > When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0, > > so validate_msg_fds() will return error. In this case, > > the negotiation of vring message between vhost user front end and > > back end would fail, and as a result, vhost user link could NOT be up. > > > > How to reproduce: > > 1.Run dpdk testpmd insides VM, which locates at host with ovs+dpdk. > > 2.Notice that inside ovs there are endless logs regarding failure to > > handle VHOST_USER_SET_VRING_CALL, and link of vm could NOT be up. > > > > Fixes: bf47225 ("vhost: fix possible denial of service by leaking FDs") > > Signed-off-by: Zhike Wang > > --- > > lib/librte_vhost/vhost_user.c | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > otherwise: > > Reviewed-by: Maxime Coquelin > > The title can be changed while applying if you agree with it, no need to > send v3. > > I'll take care of the different backports. > Reviewed-by: Tiwei Bie Thanks! Tiwei