From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D981EA04C5; Fri, 15 Nov 2019 17:23:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F6B32C12; Fri, 15 Nov 2019 17:23:33 +0100 (CET) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 3FA0B271 for ; Fri, 15 Nov 2019 17:23:32 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id n13so6926813pff.1 for ; Fri, 15 Nov 2019 08:23:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xki63dgjyepYcWXzKtqMaBhF8xEcMD7S1Cxe8jyrBFU=; b=e5q6uGNJ6KPXpsoLUvm4/p5lfkqH9ov0OCmiSKtG/D8XUKd0MbeKFeROx5UNYhFitQ yCfHoWm6kiy3Pml1O2C1+1rcrWIsEgX6HI76uc5jsugoCXQJSKL6nb0IwlQA8+Das8Rk g10bz3Vw5sXlxPr1I8sZtjukTq4gcvdEF+OVQtT88eb32JYxL5g71XJJDywvo4VsSgv5 QNGRENsdPmAPjpm8wiIkVEfFoDmMNu08jeAC6V4e2/5xCLYlimrCVHCdhvEgApDa3o77 0o4BnJbUf83zNWQ5TTFq7QY5I/M3+1GpYSu/5tVyTSBIoDyKSGHP0wYGfpUJju1KRlko w1mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xki63dgjyepYcWXzKtqMaBhF8xEcMD7S1Cxe8jyrBFU=; b=QB1AD1LAjW1bIEDNsCmANkIFxQpqCrRWmZMELqLqbsoiVIiWb2cli+ncknUunpN/VF Gz5xPdN4dEaTiMOMbOFZFKHiqRliYh18XzCvObLsxTrioGFtRB9pOElyWyDpDom1Sqo8 RtGtXplaM1UZ2I2/sNGFeIqD38Scu/zfofWrrlGw3x9thftFJr/9ekzAKLl5BNvgZKI9 UQIqffbShEi17Wp9EDNA1sNJlPyNH/a3SYpZ18nkpPY4957Sk4/V+9AD5D7roDvxwz+T Hidrq2aBWY/38kFfiSw4pu5EnmSmhCcVddfEOZ71Choo5TUdzmLTNYsH8sp/8qbWdHjw 0evQ== X-Gm-Message-State: APjAAAV9xTCRpuoV2x80x072QoieGbxGFAmkCyIWzf0xRGHFI5i9EhN7 AntsPeI7cmdC1HVBd1uAQUW+/Q== X-Google-Smtp-Source: APXvYqxigITEH99tY9M6ji2g1C002og9c2VsbQA0KvoDFis/4jDajBJS5Yk13NO91Fu0XCh7HMs69A== X-Received: by 2002:a63:f849:: with SMTP id v9mr3343471pgj.99.1573835011203; Fri, 15 Nov 2019 08:23:31 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 83sm10680524pgh.86.2019.11.15.08.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 08:23:30 -0800 (PST) Date: Fri, 15 Nov 2019 08:23:28 -0800 From: Stephen Hemminger To: Michael Pfeiffer Cc: ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20191115082328.71782fa3@hermes.lan> In-Reply-To: <20191115114107.30737-1-michael.pfeiffer@tu-ilmenau.de> References: <20191115114107.30737-1-michael.pfeiffer@tu-ilmenau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] kni: reduce interface name size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 15 Nov 2019 12:41:07 +0100 Michael Pfeiffer wrote: > The name in rte_kni_device_info is passed to the kernel, which allows > interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a > longer name currently trigger a kernel BUG in alloc_netdev_mqs in > net/core/dev.c. Reduce RTE_KNI_NAMESIZE to prevent this situation. > > Signed-off-by: Michael Pfeiffer Why not kill the NAMESIZE define in KNI and use the kernel one.