From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8C7C4A04C5;
	Fri, 15 Nov 2019 17:36:00 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5143D2C16;
	Fri, 15 Nov 2019 17:36:00 +0100 (CET)
Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com
 [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 1AE5D2C08
 for <dev@dpdk.org>; Fri, 15 Nov 2019 17:35:58 +0100 (CET)
Received: by mail-pl1-f196.google.com with SMTP id a18so4999666plm.10
 for <dev@dpdk.org>; Fri, 15 Nov 2019 08:35:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=e4msWkrKFBIprdh/hU5IjY/3pxAexP+CLgDWSVzxgKY=;
 b=DMDi4FCq2y7mN3BGtnFp0yU/BBQg3GluUQS1jRE+NY5AYWyeMq6tgcK6cW8zCpob6B
 r+4c/b4ce/I0ZGOh8liuKEcs7uRZbngJHfjZAyWdIheux9icW6hGrqd6jumRwqmm2Ypr
 GtLK4hIFD+uf2vR63YaCJJDhCfDtc6mCYZDxD89Spz8QmLXypyEx2Rvu+WAwZKNAiAws
 YQ5ZMxaVipTWk+AMw7ejZRbJy8O91RdHgysykVqFPrY2CLrp9zpPQGsFHCnJHt7/rNjb
 VeWftVQrCftCtVvfLTPpCtr9ykJJmgHlR0wN3oXTBdIn1r3YloNrySQrOEaMTNxy0Tq5
 x4cg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=e4msWkrKFBIprdh/hU5IjY/3pxAexP+CLgDWSVzxgKY=;
 b=eE3sacRHjLjv8+2j40jD3rFhrlitcFY+ZLvKxumyQMJgKd85mZjkJDawwukFf7VUqR
 Lgf6HVi6k60YVPYcAF3RwPEZLDTVhhy37YemZjKdxuEPyfDT/+ZUc78sDNIbDunZIziK
 /4NMckl0sZ6F3bXhCdeI6kyyCVtUVODYx9lPr6qevkJQLVAi5CfvLEaI//qxFsCOuqHi
 rYrbK9cyQU1p15o2782/bvgGNAGxZNXlvDuK47udv5WRV1zObXLSZnjuEQnbjmWNIzSv
 MZpfsKa/etDoT/ffbL4R7dbjc3K0sSB/vRCZPQmA5oY1yGjTJIvuUSmBN37X6GGJ7BVT
 sAAw==
X-Gm-Message-State: APjAAAUffhSRzdu/mNranLEy5v6+zkYJari+jEU2KBT0+32235RyuyGh
 ROlXp+RF3C9xXgIfEiwbIyTklg==
X-Google-Smtp-Source: APXvYqwaTsWMgj8M6OctOXmQdAyocYzKkgVCO/9eurvAOdPXS+hgXzy5fT/DFQQ7Do5ayBagj93LiQ==
X-Received: by 2002:a17:90a:ec13:: with SMTP id
 l19mr21855767pjy.0.1573835758018; 
 Fri, 15 Nov 2019 08:35:58 -0800 (PST)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id t8sm9577832pjr.25.2019.11.15.08.35.56
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 15 Nov 2019 08:35:57 -0800 (PST)
Date: Fri, 15 Nov 2019 08:35:53 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur
 <somnath.kotur@broadcom.com>, Rahul Lakkireddy
 <rahul.lakkireddy@chelsio.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, John
 Daley <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>, Qi Zhang
 <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>, Ziyang Xuan
 <xuanziyang2@huawei.com>, Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
 Guoyang Zhou <zhouguoyang@huawei.com>, Beilei Xing <beilei.xing@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>, Qiming Yang <qiming.yang@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>, Shijith Thotton
 <sthotton@marvell.com>, Srisivasubramanian Srinivasan
 <srinivasan@marvell.com>, Matan Azrad <matan@mellanox.com>, Shahaf Shuler
 <shahafs@mellanox.com>, Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
 Stephen Hemminger <sthemmin@microsoft.com>, "K. Y. Srinivasan"
 <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, Alejandro
 Lucero <alejandro.lucero@netronome.com>, Rasesh Mody <rmody@marvell.com>,
 "Shahed Shaikh" <shshaikh@marvell.com>, Jerin Jacob <jerinj@marvell.com>,
 "Maciej Czekaj" <mczekaj@marvell.com>, Yong Wang <yongwang@vmware.com>,
 <dev@dpdk.org>
Message-ID: <20191115083553.0469a4a2@hermes.lan>
In-Reply-To: <94cfd18c-5906-a4b7-e9aa-06db327af30b@solarflare.com>
References: <1573749654-30038-1-git-send-email-arybchenko@solarflare.com>
 <20191114085614.5fbaeaf9@hermes.lan>
 <94cfd18c-5906-a4b7-e9aa-06db327af30b@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/3] drivers/net: fix RSS hash offload set if
 Rx mode is RSS only
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 15 Nov 2019 12:41:16 +0300
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> Hi Stephen,
> 
> On 11/14/19 7:56 PM, Stephen Hemminger wrote:
> > On Thu, 14 Nov 2019 16:40:50 +0000
> > Andrew Rybchenko <arybchenko@solarflare.com> wrote:
> >   
> >> By default RSS hash delivery (offload) is bound to RSS mode and
> >> it is incorrect to advertise it as enabled if Rx multi-queue mode
> >> has no RSS.
> >>
> >> Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities")
> >>
> >> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>  
> > 
> > If you have to change so many drivers, why not just handle it in
> > common rte_ethdev code?  
> 
> rte_ethdev cannot set the offload itself since it has no knowledge that
> the offload cannot be disabled.
> rte_ethdev can blacklist the automatically set offloads in the case of
> non-RSS Rx multi-queue mode, but I don't like it since it adds to many
> layers where we change offloads.
> That's why I prefer this way.
> 
> Andrew.

Makes sense, just concerned that other (or new) drivers will
have same issue.