From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFA6BA04C2; Fri, 15 Nov 2019 09:48:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E4EA2F4F; Fri, 15 Nov 2019 09:48:37 +0100 (CET) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 739402C27 for ; Fri, 15 Nov 2019 09:48:35 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id z19so9443354wmk.3 for ; Fri, 15 Nov 2019 00:48:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LfvGbMzU9DZldDqisMIIB4aBvjNUJwOEB5vJg8wthvw=; b=h1yx+wxqT6M77czXPS8LU5Twk9Ii+977yroaFDl2jjtK3jIov4SHPqrOv+joSs3DUP aFaR2fS17m/ZRueuc6njwFb1xqELWqVRWnk13MpkjK449Pc0d+1NIagc/yq8sU33fhhX N1MzDz8kwl0yF46du8gIxSAvdeVHzMxCcionlPXwMYBtHoAvgDukYfaKSSBbAbDMBkAj O5A81lbkLpAIbPXeCF1y2hI87RfowY7jJgktFYufR+RQOtiMNYu1uveQdSI36y5YUa3c 5KfytC0i+hO8WPTRLFWcXOJ6+q0INZfqWmID78A9Z19d75OYMbrfDhGY/RisKgYZfum8 nJ0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LfvGbMzU9DZldDqisMIIB4aBvjNUJwOEB5vJg8wthvw=; b=LwI4u2W3xSSN5a3lPxKvd6UGx5p5tx64oiBdQKUyqPQts03nClyuHSnymIQWTKMdyW RijBmligJpo/16XtgKenZJ/jeikURsaLWVRZc5ykd4W2/dJoonRFzrTCDDRhyEi3obkx G31vk1Os9gjGHxhcWBNI+Zi2ua0c4lRqYgfwyZ0pgkMUxeAV4iGB4WXs5DwQ7HQbcUOQ TFvJ2Og9kcUvgEH/jE7dOb6D4ADTwCmZZG/34kgA5yvXXRKe9ZmC7996eFxyi7rAGJjz zPFnL+ngydEe9Rgy5Z3zfQuss2F+h+rwPLmeKc158S/pvEDABCKkI+uG2UJt9wVstAXl 6fJg== X-Gm-Message-State: APjAAAXNzwQEUbQpH+Rc4NPqsPOA3Z6sRjfvsVlUrCAOhvHY9/DvIPCX 0JF0jhYs1a4PIhMwheVcfQ5obg== X-Google-Smtp-Source: APXvYqzjyH/lPKS6d2E+aKOqZ23H8TN6aAT0pJP6LJBBIrt1rndvWf48ciJg+vBpK9MzKupDAXrzVg== X-Received: by 2002:a1c:9d4a:: with SMTP id g71mr14025936wme.66.1573807715206; Fri, 15 Nov 2019 00:48:35 -0800 (PST) Received: from 6wind.com (2a01cb0c0005a6000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id y17sm11014351wrs.58.2019.11.15.00.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 00:48:34 -0800 (PST) Date: Fri, 15 Nov 2019 09:48:34 +0100 From: Olivier Matz To: Anatoly Burakov Cc: dev@dpdk.org, Andrew Rybchenko , david.marchand@redhat.com, stable@dpdk.org Message-ID: <20191115084834.GG4841@platinum> References: <825d02ef7f7b6ab65a36d9fa4719847228537384.1573739893.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 2/2] mempool: remove check for bad IOVA when populating X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 14, 2019 at 01:58:21PM +0000, Anatoly Burakov wrote: > Currently, mempool will check if IOVA is bad for a segment, and reject > the IOVA if hugepages are also enabled. This check is wrong because now > that we have external memory segments, they are allowed to have their > IOVA's to be invalid. This check also doesn't make much sense in the > first place, because the following code can handle bad IOVA's perfectly > well (and in fact, this check is not triggering a failure when > --no-huge option is enabled), so there is not much sense to check for > this in the first place. > > Fixes: 950e8fb4e194 ("mem: allow registering external memory areas") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov Acked-by: Olivier Matz