From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16C8EA04C2; Fri, 15 Nov 2019 13:23:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 66EBE2BA8; Fri, 15 Nov 2019 13:23:29 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3B7282B86; Fri, 15 Nov 2019 13:23:28 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 04:23:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,308,1569308400"; d="scan'208";a="195377277" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga007.jf.intel.com with ESMTP; 15 Nov 2019 04:23:23 -0800 Received: from sivswdev09.ir.intel.com (sivswdev09.ir.intel.com [10.237.217.48]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id xAFCNMdl002493; Fri, 15 Nov 2019 12:23:22 GMT Received: from sivswdev09.ir.intel.com (localhost [127.0.0.1]) by sivswdev09.ir.intel.com with ESMTP id xAFCNMT4007818; Fri, 15 Nov 2019 12:23:22 GMT Received: (from lma25@localhost) by sivswdev09.ir.intel.com with LOCAL id xAFCNMr2007814; Fri, 15 Nov 2019 12:23:22 GMT Date: Fri, 15 Nov 2019 12:23:22 +0000 From: "Liang, Ma" To: Mattias =?iso-8859-1?Q?R=F6nnblom?= Cc: david.hunt@intel.com, dev@dpdk.org, alan.carew@intel.com, stable@dpdk.org Message-ID: <20191115122321.GA1082@sivswdev09.ir.intel.com> References: <20191114141036.31317-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191114141036.31317-1-mattias.ronnblom@ericsson.com> User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH] power: handle frequency increase with turbo disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Mattias, On 14 Nov 15:10, Mattias Rönnblom wrote: > Calling pstate's or acpi's rte_power_freq_up() when on the highest > non-turbo frequency results in an error, if turbo is disabled. The > error is in the form of a return code and a RTE_LOG() entry on the ERR > level. > > According to the API documentation, the frequency is scaled up > "according to the available frequencies". In case turbo is disabled, > that frequency is not available. This patch's rte_power_freq_up() > behaviour is also consistent with how rte_power_freq_max() is > implemented (i.e. the highest non-turbo frequency is set, in case > turbo is disabled). > > Fixes: 445c6528b55f ("power: common interface for guest and host") > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > Cc: stable@dpdk.org > > Signed-off-by: Mattias Rönnblom > --- Thanks for your patches. I reviewed it and I'm OK with that changes. Reviewed-by: Liang Ma