From: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
To: ferruh.yigit@intel.com
Cc: dev@dpdk.org, Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
Subject: [dpdk-dev] [PATCH v2] kni: reduce interface name size
Date: Fri, 15 Nov 2019 14:03:28 +0100 [thread overview]
Message-ID: <20191115130328.25683-1-michael.pfeiffer@tu-ilmenau.de> (raw)
In-Reply-To: <20191115114107.30737-1-michael.pfeiffer@tu-ilmenau.de>
The name in rte_kni_device_info is passed to the kernel, which allows
interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a
longer name currently trigger a kernel BUG in alloc_netdev_mqs in
net/core/dev.c. Reduce RTE_KNI_NAMESIZE to prevent this situation.
Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
---
lib/librte_eal/linux/eal/include/rte_kni_common.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/linux/eal/include/rte_kni_common.h b/lib/librte_eal/linux/eal/include/rte_kni_common.h
index 46f75a710..b427cd56c 100644
--- a/lib/librte_eal/linux/eal/include/rte_kni_common.h
+++ b/lib/librte_eal/linux/eal/include/rte_kni_common.h
@@ -15,10 +15,10 @@
#include <rte_config.h>
#endif
-/**
- * KNI name is part of memzone name.
+/*
+ * KNI name is part of memzone name. Must not exceed IFNAMSIZ.
*/
-#define RTE_KNI_NAMESIZE 32
+#define RTE_KNI_NAMESIZE 16
#define RTE_CACHE_LINE_MIN_SIZE 64
--
2.20.1
next prev parent reply other threads:[~2019-11-15 13:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 11:41 [dpdk-dev] [PATCH] " Michael Pfeiffer
2019-11-15 12:30 ` Igor Ryzhov
2019-11-15 12:43 ` Ferruh Yigit
2019-11-15 12:43 ` Michael Pfeiffer
2019-11-15 12:49 ` Ferruh Yigit
2019-11-15 12:52 ` Michael Pfeiffer
2019-11-15 13:03 ` Michael Pfeiffer [this message]
2019-11-15 13:30 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2019-11-19 21:02 ` David Marchand
2019-11-15 16:23 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2019-11-19 12:13 ` Ferruh Yigit
2019-11-19 20:58 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115130328.25683-1-michael.pfeiffer@tu-ilmenau.de \
--to=michael.pfeiffer@tu-ilmenau.de \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).