Re: [dpdk-dev] [EXT] Re: [PATCH] mk: add support for UBSAN

[Harman Kalra <hkalra@marvell.com>]

On Mon, Nov 11, 2019 at 08:07:00AM +0100, Thomas Monjalon wrote:
> External Email
> 
> ----------------------------------------------------------------------
> Hi,
> 
> Sorry for the very late review.
> I hope someone else would try it.
> 
> I tried this:
> devtools/test-build.sh -v x86_64-native-linux-clang+shared+UBSAN+SANITIZE_ALL
> and it triggers some link errors:
> /usr/bin/ld: rte_kvargs.c:(.text+0xc65): undefined reference to `__ubsan_handle_pointer_overflow'
Hi,

Thanks for trying it out. I came across these errors when compiler
versions doesn't supports UBSAN 
Can you please with latest clang version if issue still persists.
					 
> 
> 
> 19/08/2019 15:48, Harman Kalra:
> > UndefinedBehaviorSanitizer (UBSan) is a fast undefined behavior
> > detector. UBSan modifies the program at compile-time to catch
> > various kinds of undefined behavior during program execution.
> > 
> > This patch implements support for UBSan to the DPDK.
> > 
> > See: doc/guides/prog_guide/ubsan.rst for more information.
> > 
> > Signed-off-by: Harman Kalra <hkalra@marvell.com>
> > ---
> > +ifeq ($(CONFIG_RTE_UBSAN),y)
> > +ifeq ($(UBSAN_ENABLE),y)
> 
> This can be replaced with an oneline:
> 
> ifeq ($(CONFIG_RTE_UBSAN)$(UBSAN_ENABLE),yy)
Ack, will do these changes in V2
> 
> 
>