DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/e1000: fix link status update
@ 2019-11-13 17:32 Cui LunyuanX
  2019-11-14  6:41 ` Ye Xiaolong
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Cui LunyuanX @ 2019-11-13 17:32 UTC (permalink / raw)
  To: dev; +Cc: Wenzhuo Lu, Yang Qiming, Cui LunyuanX, stable

Unassigned variable should not be used as judgment, and there
is no need to update link status according to old link status.
This patch fix the issue.

Fixes: 80ba61115e77 ("net/e1000: use link status helper functions")
Cc: stable@dpdk.org

Signed-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>
---
 drivers/net/e1000/em_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index 9a88b50b2..a3d39a935 100644
--- a/drivers/net/e1000/em_ethdev.c
+++ b/drivers/net/e1000/em_ethdev.c
@@ -1157,7 +1157,7 @@ eth_em_link_update(struct rte_eth_dev *dev, int wait_to_complete)
 	memset(&link, 0, sizeof(link));
 
 	/* Now we check if a transition has happened */
-	if (link_check && (link.link_status == ETH_LINK_DOWN)) {
+	if (link_check) {
 		uint16_t duplex, speed;
 		hw->mac.ops.get_link_up_info(hw, &speed, &duplex);
 		link.link_duplex = (duplex == FULL_DUPLEX) ?
-- 
2.17.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-11-26  2:28 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 17:32 [dpdk-dev] [PATCH] net/e1000: fix link status update Cui LunyuanX
2019-11-14  6:41 ` Ye Xiaolong
2019-11-15 14:48 ` [dpdk-dev] [PATCH v2] " Lunyuan Cui
2019-11-18  3:06   ` Ye Xiaolong
2019-11-18  3:21     ` Cui, LunyuanX
2019-11-18  3:28       ` Ye Xiaolong
2019-11-18 14:58   ` [dpdk-dev] [PATCH v3] " Lunyuan Cui
2019-11-18  7:23     ` Ye Xiaolong
2019-11-19  6:43     ` Lu, Wenzhuo
2019-11-20  9:22     ` [dpdk-dev] [PATCH v4] " Lunyuan Cui
2019-11-26  2:24       ` Ye Xiaolong
2019-11-26  2:04 ` [dpdk-dev] [PATCH] " Lu, Wenzhuo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).