DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] devtools: fix example build with old pkg-config
@ 2019-11-15 10:35 Ferruh Yigit
  2019-11-15 10:41 ` Bruce Richardson
  2019-11-15 15:16 ` [dpdk-dev] [PATCH v2 0/2] support older pkg-config Bruce Richardson
  0 siblings, 2 replies; 7+ messages in thread
From: Ferruh Yigit @ 2019-11-15 10:35 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, stable, Bruce Richardson

The old version of the pkg-config [1] doesn't support '-define-prefix'
and '--path' arguments which is causing failure building the
examples [2].

Added checks for pkg-config arguments support and build examples only
if they are supported.

[1]
CentOS Linux release 7.7.1908 (Core)
pkg-config version 0.27.1

[2]
 ## Building cmdline
Unknown option --define-prefix
gmake: Entering directory
`...ild-x86-default/install-root/usr/local/share/dpdk/examples/cmdline'
rm -f build/cmdline build/cmdline-static build/cmdline-shared
test -d build && rmdir -p build || true
Unknown option --define-prefix
Unknown option --define-prefix
gcc -O3  main.c commands.c parse_obj_list.c -o build/cmdline-shared
main.c:14:28: fatal error: cmdline_rdline.h: No such file or directory
 #include <cmdline_rdline.h>

Fixes: 7f80a2102bbb ("devtools: test pkg-config file")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Bruce Richardson <bruce.richardson@intel.com>
---
 devtools/test-meson-builds.sh | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index 08e83eb5c..09ab3967b 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -133,7 +133,10 @@ load_env cc
 pc_file=$(find $DESTDIR -name libdpdk.pc)
 export PKG_CONFIG_PATH=$(dirname $pc_file):$PKG_CONFIG_PATH
 
-for example in cmdline helloworld l2fwd l3fwd skeleton timer; do
-	echo "## Building $example"
-	$MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example clean all
-done
+# Ckeck pkg-config parameter support for old versions
+if pkg-config --define-prefix --path libdpdk >/dev/null 2>&1; then
+	for example in cmdline helloworld l2fwd l3fwd skeleton timer; do
+		echo "## Building $example"
+		$MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example clean all
+	done
+fi
-- 
2.21.0


^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-11-20 21:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15 10:35 [dpdk-dev] [PATCH] devtools: fix example build with old pkg-config Ferruh Yigit
2019-11-15 10:41 ` Bruce Richardson
2019-11-15 15:16 ` [dpdk-dev] [PATCH v2 0/2] support older pkg-config Bruce Richardson
2019-11-15 15:16   ` [dpdk-dev] [PATCH v2 1/2] devtools: fix example builds with " Bruce Richardson
2019-11-15 15:17   ` [dpdk-dev] [PATCH v2 2/2] examples: suppress errors for missing pkg-config path flag Bruce Richardson
2019-11-18 11:48   ` [dpdk-dev] [PATCH v2 0/2] support older pkg-config Ferruh Yigit
2019-11-20 21:50     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).