From: Lunyuan Cui <lunyuanx.cui@intel.com>
To: dev@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Lunyuan Cui <lunyuanx.cui@intel.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH v3] net/ixgbe: fix link status
Date: Mon, 18 Nov 2019 10:13:45 +0000 [thread overview]
Message-ID: <20191118101345.42181-1-lunyuanx.cui@intel.com> (raw)
In-Reply-To: <20191113163441.90162-1-lunyuanx.cui@intel.com>
After ports reset, tx laser register will be reset. The link
status for 82599eb got from link status register was not correct.
Set tx laser disable when port resets.
ixgbe_flap_tx_laser_multispeed_fiber() can cause link status
change from down to up. This treatment should work after
port starts.
Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update")
Cc: stable@dpdk.org
Signed-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>
---
v3:
* Correct countermeasure
Don't delete ixgbe_dev_setup_link_alarm_handler().
v2:
* Change commit log
Add a log why I delete ixgbe_dev_setup_link_alarm_handler().
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 8c1caac18..260484fbf 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1188,6 +1188,7 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
diag = ixgbe_bypass_init_hw(hw);
#else
diag = ixgbe_init_hw(hw);
+ hw->mac.autotry_restart = false;
#endif /* RTE_LIBRTE_IXGBE_BYPASS */
/*
@@ -1298,6 +1299,8 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
/* enable support intr */
ixgbe_enable_intr(eth_dev);
+ ixgbe_dev_set_link_down(eth_dev);
+
/* initialize filter info */
memset(filter_info, 0,
sizeof(struct ixgbe_filter_info));
--
2.17.1
next prev parent reply other threads:[~2019-11-18 2:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 12:55 [dpdk-dev] [PATCH] " Cui LunyuanX
2019-11-13 7:17 ` Ye Xiaolong
2019-11-13 16:34 ` [dpdk-dev] [PATCH v2] " Cui LunyuanX
2019-11-13 15:06 ` Ilya Maximets
2019-11-14 3:45 ` Cui, LunyuanX
2019-11-14 11:03 ` Ilya Maximets
2019-11-18 10:13 ` Lunyuan Cui [this message]
2019-11-18 3:25 ` [dpdk-dev] [PATCH v3] " Ye Xiaolong
2019-11-18 15:37 ` [dpdk-dev] [PATCH v4] " Lunyuan Cui
2019-11-19 6:27 ` Ye Xiaolong
2019-11-19 6:39 ` Cui, LunyuanX
2019-11-26 2:05 ` Lu, Wenzhuo
2019-11-26 2:27 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118101345.42181-1-lunyuanx.cui@intel.com \
--to=lunyuanx.cui@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).