From: Stephen Hemminger <stephen@networkplumber.org>
To: Thinh Tran <thinhtr@linux.vnet.ibm.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter mode for Mellanox PMDs
Date: Mon, 18 Nov 2019 17:15:26 -0800 [thread overview]
Message-ID: <20191118171526.1d06f711@hermes.lan> (raw)
In-Reply-To: <20191118181833.541-1-thinhtr@linux.vnet.ibm.com>
On Mon, 18 Nov 2019 12:18:33 -0600
Thinh Tran <thinhtr@linux.vnet.ibm.com> wrote:
> Simple change to enable scatter for Mellanox CX4/CX5 PMDs
> to run this example
>
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
> examples/ip_reassembly/main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c
> index d59e6d02f..f881b89d1 100644
> --- a/examples/ip_reassembly/main.c
> +++ b/examples/ip_reassembly/main.c
> @@ -1109,6 +1109,9 @@ main(int argc, char **argv)
> port_conf.rx_adv_conf.rss_conf.rss_hf,
> local_port_conf.rx_adv_conf.rss_conf.rss_hf);
> }
> + /* Mellanox PMDs needs scatter mode to be explicitly enabled */
> + if (!strcmp(dev_info.driver_name, "net_mlx5"))
> + local_port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_SCATTER;
This is a bad, bad precedent.
Either fix MLX driver or enable it for all PMD's.
Forcing applications to do workarounds indicates a poor design abstraction.
next prev parent reply other threads:[~2019-11-19 1:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 18:18 Thinh Tran
2019-11-18 18:30 ` Jerin Jacob
2019-11-18 23:02 ` Thinh Tran
2019-11-19 1:15 ` Stephen Hemminger [this message]
2020-02-03 14:43 ` Slava Ovsiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118171526.1d06f711@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=thinhtr@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).