From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C323AA04C0; Tue, 19 Nov 2019 02:15:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96BD8B62; Tue, 19 Nov 2019 02:15:32 +0100 (CET) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 65F50A69 for ; Tue, 19 Nov 2019 02:15:31 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id n13so11273523pff.1 for ; Mon, 18 Nov 2019 17:15:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9aOs3L/gf4qauX+NEEhFVobfFzg1M3jaLJJU6Db/Csk=; b=vUDZmIG/bxaT5B5rz7cz3jir1fKSBz+6CL6gZPZ6O5i833yMx7rk6XoHwh3z0PMSa9 705PCLhEJRFBc0CkvIlSHboOHSzbDFqCdeY5xS8+hJZEzQcN+R5oKguGC/gRxSKdh9g5 zNpBn4enz9MgyTB2ETn91pDRCs11kR5Whj7Dr/qOZCmTEYadAPTCn/Kgh6fbmbT3lu0a FkQV3NFE7+W4WH1aK28eikS44EBM5nShDgLZGEfwwBOHn2/cB8muMONbrJm/mGCzsdo6 EpDIHQhZsgw/oq5KobRtFl5lDlkc7RnjyuW4t5I45If2qjfYKx77/0KPkGQoFqcsOsag JF4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9aOs3L/gf4qauX+NEEhFVobfFzg1M3jaLJJU6Db/Csk=; b=ny/qmp82S2uBKG6ojVfPeQZbQ2gZAqEDx46vadxHtqJEAkbYF+lwn9zm61LmhHINZM gs9p+J5pKHHRof+B2WwF/xnlEqFniuUoZZIqE5F3290UVob/1SPj/nVyb/wO1e+Tk+fL ljt4iFQBR/TDFFPZkNkmy83fbXyFHPAbByf2L+7spkDtPtVrLKhj/sUxebqjDXcpSWSf +ZO2AC0kCO72DM+yuT3q44aX0j/6XvqU5TTi4D8QYfH8V2TJRvR95XikocU2Ckx9t9hi IH1p2NmHDO4DOhYQzmP468aZebl+ydGOGEN5jGg+NhrICfXBYzpznnQcA/N0yeZHDrhH g5dw== X-Gm-Message-State: APjAAAXROedsrkfrHhqUsmHdBMpP0PmEBQr/sfXgIvmveSPRXyqcJg1i 0o2+yID/bolUSnFgcM1rk5Iz8w== X-Google-Smtp-Source: APXvYqxHG0ePb8aywdc7hSydtxdKLdR5dcaEcLs8c3F95d2FQQPN2aZQraPBkAQ66F5VrmzBxOC/xA== X-Received: by 2002:a62:fc84:: with SMTP id e126mr2465029pfh.97.1574126130515; Mon, 18 Nov 2019 17:15:30 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w15sm21480502pfn.13.2019.11.18.17.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 17:15:30 -0800 (PST) Date: Mon, 18 Nov 2019 17:15:26 -0800 From: Stephen Hemminger To: Thinh Tran Cc: dev@dpdk.org Message-ID: <20191118171526.1d06f711@hermes.lan> In-Reply-To: <20191118181833.541-1-thinhtr@linux.vnet.ibm.com> References: <20191118181833.541-1-thinhtr@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter mode for Mellanox PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 18 Nov 2019 12:18:33 -0600 Thinh Tran wrote: > Simple change to enable scatter for Mellanox CX4/CX5 PMDs > to run this example > > Signed-off-by: Thinh Tran > --- > examples/ip_reassembly/main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c > index d59e6d02f..f881b89d1 100644 > --- a/examples/ip_reassembly/main.c > +++ b/examples/ip_reassembly/main.c > @@ -1109,6 +1109,9 @@ main(int argc, char **argv) > port_conf.rx_adv_conf.rss_conf.rss_hf, > local_port_conf.rx_adv_conf.rss_conf.rss_hf); > } > + /* Mellanox PMDs needs scatter mode to be explicitly enabled */ > + if (!strcmp(dev_info.driver_name, "net_mlx5")) > + local_port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_SCATTER; This is a bad, bad precedent. Either fix MLX driver or enable it for all PMD's. Forcing applications to do workarounds indicates a poor design abstraction.