From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3D89A034E; Tue, 19 Nov 2019 17:25:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CDD8A69; Tue, 19 Nov 2019 17:25:21 +0100 (CET) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id D76AA2AB for ; Tue, 19 Nov 2019 17:25:19 +0100 (CET) Received: by mail-pl1-f193.google.com with SMTP id l4so12007922plt.13 for ; Tue, 19 Nov 2019 08:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jZe7SeA9u+Di/UjuEb+/LfTMPffOfpbYIk9AcBNXLSs=; b=k40Bw3S+Z/fbS5/DJ1qWFQeWwUZN9eDory/dRG8Un5Bo0tR3w/k/C2/EXnJjiGBTO8 Rr2WH48UQv0N+9xTxUtcmLdljdCZ10kljMl6bDWzaViY7L7zsSLCNtoVpNmK3eRoimf0 Tje65D5WUDfnCFxpkQPiQR6CkdEjA5yEWOkf+QxrwlA5mp9M9VsLTv0Nd9LxfbAXJfbF h+t2JZtLBn4Vifl8VTh4SbHU29YEMJm0Tr0WYtNl/Dvmq2DEZLbvgikRJ7DbZk7hsWK+ VL3PeWApgwPdykbbqP19S5AIHCC/rcMuuIWL4hA2dBYs8QCrYC56Po6u7PZ4jzRloOyG Dr8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jZe7SeA9u+Di/UjuEb+/LfTMPffOfpbYIk9AcBNXLSs=; b=YfS//jnwjhFLtafRiYN3XPa7mGnK/3m3yKq1HvmC9BgDe8ihJcuWbsZD3+GYoA/e92 uSgar8+MB57DaSBvR4+iFEKcZe7JuK65vJ2dp2nAQ0tzdZdpKh0545zimLLpvSqnRnUX WwmcbB0ySfHQNjBCOjygLUKpXcRuBpZB65BQNkk9j18T1iBj/I/yzUu/OF85cIEqaOJ4 6PTTdDsJxHNidx4ygfQm68N/Ak1apaHA7vtpCakFSjplf3gWKppCawr5KKK1g0ro8Di2 gTlul1ItHDS0nC2QdCF91tCyPvDEannoKzGvoRnAhRS1l7xajCEKfUxPrZP7J+FlQb4I uA2Q== X-Gm-Message-State: APjAAAUyUbWk/PO+9flnIvwb4+q/AfAmxfLEV7NzlZz0kLkvlBe3+JE+ IEeFnEHTAjfNsCx/i04N4YBsHw== X-Google-Smtp-Source: APXvYqzaCqNy1Xqqb7Rx1qNKEzuumT4gi4PA5uF60naCYUxPJiaCmJ+fMb0Q/Iuskyq1xj2CWJelKw== X-Received: by 2002:a17:902:b101:: with SMTP id q1mr29365890plr.154.1574180718761; Tue, 19 Nov 2019 08:25:18 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w26sm28172113pfj.123.2019.11.19.08.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2019 08:25:18 -0800 (PST) Date: Tue, 19 Nov 2019 08:25:15 -0800 From: Stephen Hemminger To: Shahaf Shuler Cc: Thomas Monjalon , "olivier.matz@6wind.com" , "dev@dpdk.org" Message-ID: <20191119082515.41848e4e@hermes.lan> In-Reply-To: References: <20191118100247.74241-1-shahafs@mellanox.com> <13010452.zfGL6P0G4r@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 19 Nov 2019 15:23:50 +0000 Shahaf Shuler wrote: > Tuesday, November 19, 2019 11:33 AM, Thomas Monjalon: > > Subject: Re: [PATCH] mbuf: extend pktmbuf pool private structure > > > > 18/11/2019 11:02, Shahaf Shuler: > > > struct rte_pktmbuf_pool_private { > > > uint16_t mbuf_data_room_size; /**< Size of data space in each > > mbuf. */ > > > uint16_t mbuf_priv_size; /**< Size of private area in each mbuf. > > */ > > > + uint32_t reserved; /**< reserved for future use. */ > > > > Maybe simpler to give the future name "flags" and keep the comment > > "reserved for future use". > > I'm am OK w/ changing to flags. > If Olivier accepts maybe you can change while applying? After the Linux openat experience if you want to add flags. Then all usage of API needs to validate that flags is 0.