From: Bruce Richardson <bruce.richardson@intel.com>
To: Reshma Pattan <reshma.pattan@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] doc: update git fixline alias with cc to stable
Date: Tue, 19 Nov 2019 11:22:35 +0000 [thread overview]
Message-ID: <20191119112235.GA1536@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20191119110357.24019-1-reshma.pattan@intel.com>
On Tue, Nov 19, 2019 at 11:03:57AM +0000, Reshma Pattan wrote:
> Update git fixline alias to add stable@dpdk.org to Cc
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> doc/guides/contributing/patches.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
> index 214030346..fa19d2eb5 100644
> --- a/doc/guides/contributing/patches.rst
> +++ b/doc/guides/contributing/patches.rst
> @@ -255,7 +255,7 @@ Here are some guidelines for the body of a commit message:
> You can generate the required lines using the following git alias, which prints
> the commit SHA and the author of the original code::
>
> - git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'"
> + git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae%nCc: stable@dpdk.org'"
>
> The output of ``git fixline <SHA>`` must then be added to the commit message::
>
While a good idea, we don't always want to CC stable for all fixes, as
fixes for commits in the current release obviously don't need backports.
I suggest the stable maintainers comment on whether receiving these
additional patches would be a problem for them, or if their tooling is
sufficiency advanced for them to ignore these without issue...
/Bruce
next prev parent reply other threads:[~2019-11-19 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 11:03 Reshma Pattan
2019-11-19 11:22 ` Bruce Richardson [this message]
2019-11-19 14:40 ` Kevin Traynor
2019-11-20 20:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119112235.GA1536@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).