From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCCA4A0353; Tue, 19 Nov 2019 12:22:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B2DF123D; Tue, 19 Nov 2019 12:22:42 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 35D52237 for ; Tue, 19 Nov 2019 12:22:40 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2019 03:22:40 -0800 X-IronPort-AV: E=Sophos;i="5.68,322,1569308400"; d="scan'208";a="200321315" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 19 Nov 2019 03:22:38 -0800 Date: Tue, 19 Nov 2019 11:22:35 +0000 From: Bruce Richardson To: Reshma Pattan Cc: dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20191119112235.GA1536@bricha3-MOBL.ger.corp.intel.com> References: <20191119110357.24019-1-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191119110357.24019-1-reshma.pattan@intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] doc: update git fixline alias with cc to stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 19, 2019 at 11:03:57AM +0000, Reshma Pattan wrote: > Update git fixline alias to add stable@dpdk.org to Cc > > Signed-off-by: Reshma Pattan > --- > doc/guides/contributing/patches.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst > index 214030346..fa19d2eb5 100644 > --- a/doc/guides/contributing/patches.rst > +++ b/doc/guides/contributing/patches.rst > @@ -255,7 +255,7 @@ Here are some guidelines for the body of a commit message: > You can generate the required lines using the following git alias, which prints > the commit SHA and the author of the original code:: > > - git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'" > + git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae%nCc: stable@dpdk.org'" > > The output of ``git fixline `` must then be added to the commit message:: > While a good idea, we don't always want to CC stable for all fixes, as fixes for commits in the current release obviously don't need backports. I suggest the stable maintainers comment on whether receiving these additional patches would be a problem for them, or if their tooling is sufficiency advanced for them to ignore these without issue... /Bruce