* [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list
@ 2019-11-20 4:29 Ajit Khaparde
2019-11-20 4:29 ` [dpdk-dev] [PATCH 2/2] net/bnxt: fix check for null spec and mask Ajit Khaparde
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ajit Khaparde @ 2019-11-20 4:29 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
Updating bnxt.ini file.
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
doc/guides/nics/features/bnxt.ini | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/guides/nics/features/bnxt.ini b/doc/guides/nics/features/bnxt.ini
index 9721dd61d..37a99e336 100644
--- a/doc/guides/nics/features/bnxt.ini
+++ b/doc/guides/nics/features/bnxt.ini
@@ -11,6 +11,7 @@ Rx interrupt = Y
Queue start/stop = Y
MTU update = Y
Jumbo frame = Y
+Scattered Rx = Y
LRO = Y
TSO = Y
Promiscuous mode = Y
@@ -37,9 +38,11 @@ Rx descriptor status = Y
Tx descriptor status = Y
Basic stats = Y
Extended stats = Y
+Stats per queue = Y
FW version = Y
EEPROM dump = Y
LED = Y
+Multiprocess aware = Y
Linux UIO = Y
Linux VFIO = Y
ARMv8 = Y
--
2.21.0 (Apple Git-122.2)
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH 2/2] net/bnxt: fix check for null spec and mask
2019-11-20 4:29 [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list Ajit Khaparde
@ 2019-11-20 4:29 ` Ajit Khaparde
2019-11-20 5:01 ` Ajit Khaparde
2019-11-20 5:02 ` [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list Ajit Khaparde
2019-11-20 9:41 ` Ferruh Yigit
2 siblings, 1 reply; 6+ messages in thread
From: Ajit Khaparde @ 2019-11-20 4:29 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Santoshkumar Karanappa Rastapur, Somnath Kotur
bnxt_validate_and_parse_flow_type already has protocol specific NULL
checks for rte_flow_item spec and mask and take actions accordingly.
A check at the top of the loop is redundant and is preventing the
protocol specific checks from being executed.
Fixes: b7e01f386059 ("net/bnxt: handle cleanup if flow creation fails")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_flow.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
index 5af571448..76e9584da 100644
--- a/drivers/net/bnxt/bnxt_flow.c
+++ b/drivers/net/bnxt/bnxt_flow.c
@@ -177,14 +177,6 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,
return -rte_errno;
}
- if (!item->spec || !item->mask) {
- rte_flow_error_set(error, EINVAL,
- RTE_FLOW_ERROR_TYPE_ITEM,
- item,
- "spec/mask is NULL");
- return -rte_errno;
- }
-
switch (item->type) {
case RTE_FLOW_ITEM_TYPE_ANY:
inner =
--
2.21.0 (Apple Git-122.2)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix check for null spec and mask
2019-11-20 4:29 ` [dpdk-dev] [PATCH 2/2] net/bnxt: fix check for null spec and mask Ajit Khaparde
@ 2019-11-20 5:01 ` Ajit Khaparde
0 siblings, 0 replies; 6+ messages in thread
From: Ajit Khaparde @ 2019-11-20 5:01 UTC (permalink / raw)
To: dpdk-dev; +Cc: Ferruh Yigit, Santoshkumar Karanappa Rastapur, Somnath Kotur
On Tue, Nov 19, 2019 at 8:29 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:
> bnxt_validate_and_parse_flow_type already has protocol specific NULL
> checks for rte_flow_item spec and mask and take actions accordingly.
> A check at the top of the loop is redundant and is preventing the
> protocol specific checks from being executed.
>
> Fixes: b7e01f386059 ("net/bnxt: handle cleanup if flow creation fails")
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Santoshkumar Karanappa Rastapur <
> santosh.rastapur@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_flow.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
> index 5af571448..76e9584da 100644
> --- a/drivers/net/bnxt/bnxt_flow.c
> +++ b/drivers/net/bnxt/bnxt_flow.c
> @@ -177,14 +177,6 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,
> return -rte_errno;
> }
>
> - if (!item->spec || !item->mask) {
> - rte_flow_error_set(error, EINVAL,
> - RTE_FLOW_ERROR_TYPE_ITEM,
> - item,
> - "spec/mask is NULL");
> - return -rte_errno;
> - }
> -
> switch (item->type) {
> case RTE_FLOW_ITEM_TYPE_ANY:
> inner =
> --
> 2.21.0 (Apple Git-122.2)
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list
2019-11-20 4:29 [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list Ajit Khaparde
2019-11-20 4:29 ` [dpdk-dev] [PATCH 2/2] net/bnxt: fix check for null spec and mask Ajit Khaparde
@ 2019-11-20 5:02 ` Ajit Khaparde
2019-11-20 9:41 ` Ferruh Yigit
2 siblings, 0 replies; 6+ messages in thread
From: Ajit Khaparde @ 2019-11-20 5:02 UTC (permalink / raw)
To: dpdk-dev; +Cc: Ferruh Yigit
On Tue, Nov 19, 2019 at 8:29 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:
> Updating bnxt.ini file.
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
Patch applied to dpdk-next-net-brcm.
> ---
> doc/guides/nics/features/bnxt.ini | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/doc/guides/nics/features/bnxt.ini
> b/doc/guides/nics/features/bnxt.ini
> index 9721dd61d..37a99e336 100644
> --- a/doc/guides/nics/features/bnxt.ini
> +++ b/doc/guides/nics/features/bnxt.ini
> @@ -11,6 +11,7 @@ Rx interrupt = Y
> Queue start/stop = Y
> MTU update = Y
> Jumbo frame = Y
> +Scattered Rx = Y
> LRO = Y
> TSO = Y
> Promiscuous mode = Y
> @@ -37,9 +38,11 @@ Rx descriptor status = Y
> Tx descriptor status = Y
> Basic stats = Y
> Extended stats = Y
> +Stats per queue = Y
> FW version = Y
> EEPROM dump = Y
> LED = Y
> +Multiprocess aware = Y
> Linux UIO = Y
> Linux VFIO = Y
> ARMv8 = Y
> --
> 2.21.0 (Apple Git-122.2)
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list
2019-11-20 4:29 [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list Ajit Khaparde
2019-11-20 4:29 ` [dpdk-dev] [PATCH 2/2] net/bnxt: fix check for null spec and mask Ajit Khaparde
2019-11-20 5:02 ` [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list Ajit Khaparde
@ 2019-11-20 9:41 ` Ferruh Yigit
2019-11-20 16:55 ` Ajit Khaparde
2 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2019-11-20 9:41 UTC (permalink / raw)
To: Ajit Khaparde, dev
On 11/20/2019 4:29 AM, Ajit Khaparde wrote:
> Updating bnxt.ini file.
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> doc/guides/nics/features/bnxt.ini | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/doc/guides/nics/features/bnxt.ini b/doc/guides/nics/features/bnxt.ini
> index 9721dd61d..37a99e336 100644
> --- a/doc/guides/nics/features/bnxt.ini
> +++ b/doc/guides/nics/features/bnxt.ini
> @@ -11,6 +11,7 @@ Rx interrupt = Y
> Queue start/stop = Y
> MTU update = Y
> Jumbo frame = Y
> +Scattered Rx = Y
> LRO = Y
> TSO = Y
> Promiscuous mode = Y
> @@ -37,9 +38,11 @@ Rx descriptor status = Y
> Tx descriptor status = Y
> Basic stats = Y
> Extended stats = Y
> +Stats per queue = Y
> FW version = Y
> EEPROM dump = Y
> LED = Y
> +Multiprocess aware = Y
> Linux UIO = Y
> Linux VFIO = Y
> ARMv8 = Y
>
Are these features added in this release or adding the missed features? If
adding missed features can you please add the fixes tags for backtrace?
And if new features can you please put the commit providing these features for
reference?
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list
2019-11-20 9:41 ` Ferruh Yigit
@ 2019-11-20 16:55 ` Ajit Khaparde
0 siblings, 0 replies; 6+ messages in thread
From: Ajit Khaparde @ 2019-11-20 16:55 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dpdk-dev
On Wed, Nov 20, 2019 at 1:42 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 11/20/2019 4:29 AM, Ajit Khaparde wrote:
> > Updating bnxt.ini file.
> >
> > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > ---
> > doc/guides/nics/features/bnxt.ini | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/doc/guides/nics/features/bnxt.ini
> b/doc/guides/nics/features/bnxt.ini
> > index 9721dd61d..37a99e336 100644
> > --- a/doc/guides/nics/features/bnxt.ini
> > +++ b/doc/guides/nics/features/bnxt.ini
> > @@ -11,6 +11,7 @@ Rx interrupt = Y
> > Queue start/stop = Y
> > MTU update = Y
> > Jumbo frame = Y
> > +Scattered Rx = Y
> > LRO = Y
> > TSO = Y
> > Promiscuous mode = Y
> > @@ -37,9 +38,11 @@ Rx descriptor status = Y
> > Tx descriptor status = Y
> > Basic stats = Y
> > Extended stats = Y
> > +Stats per queue = Y
> > FW version = Y
> > EEPROM dump = Y
> > LED = Y
> > +Multiprocess aware = Y
> > Linux UIO = Y
> > Linux VFIO = Y
> > ARMv8 = Y
> >
>
> Are these features added in this release or adding the missed features?
Yes. Catching up on that. We missed updating this when the feature patches
went in.
> If
> adding missed features can you please add the fixes tags for backtrace?
> And if new features can you please put the commit providing these features
> for
> reference?
>
Will do.
>
> Thanks.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-20 16:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-20 4:29 [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list Ajit Khaparde
2019-11-20 4:29 ` [dpdk-dev] [PATCH 2/2] net/bnxt: fix check for null spec and mask Ajit Khaparde
2019-11-20 5:01 ` Ajit Khaparde
2019-11-20 5:02 ` [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list Ajit Khaparde
2019-11-20 9:41 ` Ferruh Yigit
2019-11-20 16:55 ` Ajit Khaparde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).