From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8EBDA04C1; Thu, 21 Nov 2019 17:43:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7EA582BA8; Thu, 21 Nov 2019 17:43:22 +0100 (CET) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 4EFAF2BA3 for ; Thu, 21 Nov 2019 17:43:21 +0100 (CET) Received: by mail-pl1-f194.google.com with SMTP id o9so1812470plk.6 for ; Thu, 21 Nov 2019 08:43:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kd5BerUT7JG2snjz/G4RC/7n9oilvBMytxmBdX5BC7A=; b=s5C/wtf1UpR3FbBFQ9XNy5OyjXMWMGFFBDWwoiVFal6Mdo05qsheSDBIJSI/6dYGF4 MrvYs6MNifM9D60nKzQIYmU2WMX6lwDzHmOnCS1MIFqiaIkHcihzkhPqHJDwXgZR7Y9j p85T8sIUYkIhxUPOrjdHmd+oygm5LyE3wFeC9Kl9lFrCF4NWREyBqZ5M543K63cyuLES uR8XKjE3fauZ9Duj4rhB81JJQyiqjQrLRZsTqJfZ07ADRxDAu6J44Z4Bxv5w5kZDBDS0 TvbkYPHIoKyJDN/U+StIcLgsn7KCZcT/u/vxDA9yOVCXOdcmAxaUWEwAohLzYU3hBU4f hbXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kd5BerUT7JG2snjz/G4RC/7n9oilvBMytxmBdX5BC7A=; b=tU6cWOV2R1HV/NfCx+xUNuAI+wzDIE0VPMPoyQ4qUYOAFniNSKdXeayCiAydI/7HxY 2x+64mC/rYldaB5uNrkaAAu+1n11mCwe/TLuhMDQw2g8C4qsOONQdOjOmZ6ibi6wAg+Y z+I+QMvZEAyr3z01ADCb145g1ZZkovs2n7nLRcic2Q5bO2PsfKQAv2+7Ksai1jmGCsTS beLvyEGbwWP5GgIeb1G5n4qNI0f9ctgncCG3y5HDneohOXfJcRmmVbv+Wfx55fdRwlGx 8rM1mDq3FUQtXN7du3avljiMCTo7tIyFZi1rTF9xsMB06P/nkd1VS8nm2aohA040qmMb oaqw== X-Gm-Message-State: APjAAAWoL6jMADwgnzjK3Zo119BXhKEcCSPzcyyw/LGJ/eg7XzUxnJM1 y98w2fHbpeJAFZuxCIqgL3IwTrBjX8Zj9A== X-Google-Smtp-Source: APXvYqyhl1Kc2jqB8heRILhMecrGOBTbA+c047hd9zccJLLaQ0EKrMYtdJLBWsDmzr35A8U2FSAo9g== X-Received: by 2002:a17:90a:bcf:: with SMTP id x15mr13047642pjd.0.1574354600279; Thu, 21 Nov 2019 08:43:20 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b24sm4084983pfi.148.2019.11.21.08.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2019 08:43:20 -0800 (PST) Date: Thu, 21 Nov 2019 08:43:17 -0800 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: Message-ID: <20191121084317.169ea71e@hermes.lan> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C60C1B@smartserver.smartshare.dk> References: <20191120174125.23704-1-stephen@networkplumber.org> <98CBD80474FA8B44BF855DF32C47DC35C60C1B@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] mbuf: display more fields in dump X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 21 Nov 2019 17:16:42 +0100 Morten Br=C3=B8rup wrote: > Are all these explicit type casts really needed? buf_iova is already uint= 64_t, buflen is uint16_t, data_off is uint16_t, rte_mbuf_refcnt_read() retu= rns uint16_t, pkt_len is uint32_t, nb_segs is uint16_t, port is uint16_t, v= lan_tci is uint16_t. Normally, they are not needed. If you turn up some of the warning levels in Gcc, then yes. >=20 > m->port is not only the input port anymore (ref. the mbuf documentation),= so please change in_port=3D%u to port=3D%u. Makes sense, but since this in internal would rather keep existing to print the name of the field. >=20 > For consistency with ol_flags and vlan_tci format, consider changing iova= =3D% to iova=3D%#. good idea, personal preference is to always use %#x over %x