From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption
Date: Thu, 21 Nov 2019 08:45:18 -0800 [thread overview]
Message-ID: <20191121084518.488dc568@hermes.lan> (raw)
In-Reply-To: <20191121151256.20613-1-david.marchand@redhat.com>
On Thu, 21 Nov 2019 16:12:55 +0100
David Marchand <david.marchand@redhat.com> wrote:
> - uint16_t nb_rx_desc[MAX_QUEUE_ID+1]; /**< per queue rx desc number */
> - uint16_t nb_tx_desc[MAX_QUEUE_ID+1]; /**< per queue tx desc number */
> - struct rte_eth_rxconf rx_conf[MAX_QUEUE_ID+1]; /**< per queue rx configuration */
> - struct rte_eth_txconf tx_conf[MAX_QUEUE_ID+1]; /**< per queue tx configuration */
> + uint16_t nb_rx_desc[RTE_MAX_QUEUES_PER_PORT+1]; /**< per queue rx desc number */
> + uint16_t nb_tx_desc[RTE_MAX_QUEUES_PER_PORT+1]; /**< per queue tx desc number */
> + struct rte_eth_rxconf rx_conf[RTE_MAX_QUEUES_PER_PORT+1]; /**< per queue rx configuration */
> + struct rte_eth_txconf tx_conf[RTE_MAX_QUEUES_PER_PORT+1]; /**< per queue tx configuration */
Why not put all the per-queue stuff together in one structure
and put it at the end. Then dynamically size based on number of queues?
next prev parent reply other threads:[~2019-11-21 16:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 15:12 David Marchand
2019-11-21 15:36 ` Ferruh Yigit
2019-11-21 16:17 ` David Marchand
2019-11-21 16:23 ` David Marchand
2019-11-21 21:22 ` Thomas Monjalon
2019-11-21 16:45 ` Stephen Hemminger [this message]
2019-11-21 20:32 ` David Marchand
2019-11-21 21:25 ` Thomas Monjalon
2019-11-21 21:55 ` Thomas Monjalon
2019-11-22 10:43 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-11-22 12:24 ` Ferruh Yigit
2019-11-22 13:12 ` Thomas Monjalon
2019-11-22 13:14 ` Ferruh Yigit
2019-11-22 13:48 ` [dpdk-dev] [PATCH] devtools: disable automatic probing in null testing Thomas Monjalon
2019-11-22 13:56 ` Ferruh Yigit
2019-11-22 15:56 ` David Marchand
2019-11-24 22:52 ` Thomas Monjalon
2019-11-22 14:03 ` Gaëtan Rivet
2019-11-22 14:36 ` Thomas Monjalon
2019-11-22 14:14 ` [dpdk-dev] [PATCH v2] app/testpmd: reduce memory consumption Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121084518.488dc568@hermes.lan \
--to=stephen@networkplumber.org \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).