From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5589FA04C1; Thu, 21 Nov 2019 17:45:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC6352BA3; Thu, 21 Nov 2019 17:45:24 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by dpdk.org (Postfix) with ESMTP id 291C82BA2 for ; Thu, 21 Nov 2019 17:45:23 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id m71so1704058pjb.12 for ; Thu, 21 Nov 2019 08:45:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uaxUEAKR3UMBnHa36WGl1F6vToVj8LZTR6pu5ywCLJA=; b=xI0qnh3wiC2HEbPj02s+boes5V94XkowMzVqjFc73h9qIcFl1EJ8mY4mO9PliopA6r Eln1Fr1sdb8nQMPiMCzd2AQgflHmNptbKEl5wrFTlaHiVonTByktjYCtc8BT1746pqof 1lB9fJEzHjKpU6+UAKi7YkbumpBFLvS/5Fm9P0CybaTXYu3tiT0SyDBSHC63zgq+shGx HbqDs/Ii8hcY5hKWCSBIWFv5yegxTAf+dW4y/ECP/ABClaOWq4ZfIKEsAjaEuQepXFvd fAPoFZEZNz8oKE+3bIOkqTIEDeSRisn1LCGu1NQpwLb8uPpyv8P7FZNz+68mXtBJEABS qZmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uaxUEAKR3UMBnHa36WGl1F6vToVj8LZTR6pu5ywCLJA=; b=msayfR9rP3QwQS0b5KIRgmrQ3R6t1K+0IhS6swg3Zs86FVK6SJvkvg+E2q1dNJ6ZrC H7vsPOn0uR04n1w49A2o9wIt29Vh//JHf84F0B2R6KfvmZIJ6cGC69ICnLExJERCVwzu gS7RpAnsvT/Udr5WknRcASgzAF9bicsP8v0LbLdnRpTmnfj8+amHc04uUlW6l/fTcFvm jljQpfmBFLgQWV8FFah13zpUasTXsjulZYu9uuX8HldkBOn7ONrIpflnwfgwpuLwDoVK ezPQyHHMbB80HC69bfN3PEm9vPHnh7SZY+LdHJdcFcZuFbBPEL5ksn11baiMMcAAYHM8 VjdQ== X-Gm-Message-State: APjAAAXF1uH3j17/MKGdpzfFc/VoKUB7erTRFRzyiS2+6LFOx4tfK022 7+bdsRoureT18gqPkiapvN5xGg== X-Google-Smtp-Source: APXvYqwyBV3+aTm79HOTNzHhWVijaysYZVmhHzX91MQdp1OKjQJ+7uHHuohhHehTZmZf1AvrvY4KBQ== X-Received: by 2002:a17:90a:1a56:: with SMTP id 22mr12930120pjl.100.1574354722221; Thu, 21 Nov 2019 08:45:22 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id h66sm4206882pfg.23.2019.11.21.08.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2019 08:45:21 -0800 (PST) Date: Thu, 21 Nov 2019 08:45:18 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger Message-ID: <20191121084518.488dc568@hermes.lan> In-Reply-To: <20191121151256.20613-1-david.marchand@redhat.com> References: <20191121151256.20613-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 21 Nov 2019 16:12:55 +0100 David Marchand wrote: > - uint16_t nb_rx_desc[MAX_QUEUE_ID+1]; /**< per queue rx desc number */ > - uint16_t nb_tx_desc[MAX_QUEUE_ID+1]; /**< per queue tx desc number */ > - struct rte_eth_rxconf rx_conf[MAX_QUEUE_ID+1]; /**< per queue rx configuration */ > - struct rte_eth_txconf tx_conf[MAX_QUEUE_ID+1]; /**< per queue tx configuration */ > + uint16_t nb_rx_desc[RTE_MAX_QUEUES_PER_PORT+1]; /**< per queue rx desc number */ > + uint16_t nb_tx_desc[RTE_MAX_QUEUES_PER_PORT+1]; /**< per queue tx desc number */ > + struct rte_eth_rxconf rx_conf[RTE_MAX_QUEUES_PER_PORT+1]; /**< per queue rx configuration */ > + struct rte_eth_txconf tx_conf[RTE_MAX_QUEUES_PER_PORT+1]; /**< per queue tx configuration */ Why not put all the per-queue stuff together in one structure and put it at the end. Then dynamically size based on number of queues?