From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E41E5A04C1; Thu, 21 Nov 2019 19:27:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 971862BA2; Thu, 21 Nov 2019 19:27:26 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 85FD1237 for ; Thu, 21 Nov 2019 19:27:25 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xALIQKfP021971; Thu, 21 Nov 2019 10:27:24 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0818; bh=zrthYzqdirT4AeL0+AVPnuSEYtUrksZRLnafr76y4hA=; b=wnkfirNXhyO9KKmkpYXmBGMu71Ge3UHuQPxKqL18ydlYOq/gEp7+LcIXGlSwv0JoKyC1 SkPOMjOcQFDY1qc2BUuLWosW3lnRU3xTM4QpR4mZjVdEQotasGB9uegULbNrBstpQS1e MWd74N6BC1irKoEMoCmu+XuyylHzD53EqdHypB09DiiWpP7EBJAicPlHDi/KCg3Xr4AI UuI0SDhfHl+Y8ryFXEf0/ChazvjcpRZWpiL3rCCtkxmgUCyi28oh6U2FLCfBBsVsmPST Y3s0KB2ccxWbh+aLb6yzxHxCL7yWprRFoULLwAlATwTPco4TsM/fr1F1jngIri1+JhMU ag== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2wd0910ds1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 21 Nov 2019 10:27:24 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 21 Nov 2019 10:27:22 -0800 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 21 Nov 2019 10:27:22 -0800 Received: from BG-LT7430.marvell.com (unknown [10.28.17.72]) by maili.marvell.com (Postfix) with ESMTP id 93E7F3F7044; Thu, 21 Nov 2019 10:27:19 -0800 (PST) From: To: , Marko Kovacevic , Ori Kam , Bruce Richardson , "Radu Nicolau" , Akhil Goyal , "Tomasz Kantecki" , Sunil Kumar Kori , Pavan Nikhilesh CC: Date: Thu, 21 Nov 2019 23:57:15 +0530 Message-ID: <20191121182718.7851-1-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-21_05:2019-11-21,2019-11-21 signatures=0 Subject: [dpdk-dev] [PATCH 1/2] examples/l2fwd-event: validate function return values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavan Nikhilesh Validate `rte_eth_link_get_nowait`, `rte_service_map_lcore_set` and `rte_eth_dev_info_get` return values. Coverity issue: 350600 Coverity issue: 350601 Coverity issue: 350602 Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_common.c | 6 +++++- examples/l2fwd-event/l2fwd_event.c | 7 ++++--- examples/l2fwd-event/main.c | 10 +++++++++- 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/examples/l2fwd-event/l2fwd_common.c b/examples/l2fwd-event/l2fwd_common.c index 4ba788550..0c069ec35 100644 --- a/examples/l2fwd-event/l2fwd_common.c +++ b/examples/l2fwd-event/l2fwd_common.c @@ -41,7 +41,11 @@ l2fwd_event_init_ports(struct l2fwd_resources *rsrc) /* init port */ printf("Initializing port %u... ", port_id); fflush(stdout); - rte_eth_dev_info_get(port_id, &dev_info); + + ret = rte_eth_dev_info_get(port_id, &dev_info); + if (ret != 0) + rte_panic("Error during getting device (port %u) info: %s\n", + port_id, strerror(-ret)); if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) local_port_conf.txmode.offloads |= DEV_TX_OFFLOAD_MBUF_FAST_FREE; diff --git a/examples/l2fwd-event/l2fwd_event.c b/examples/l2fwd-event/l2fwd_event.c index c7782cbc5..0379c580d 100644 --- a/examples/l2fwd-event/l2fwd_event.c +++ b/examples/l2fwd-event/l2fwd_event.c @@ -41,8 +41,9 @@ l2fwd_event_service_enable(uint32_t service_id) /* Get the core which has least number of services running. */ while (slcore_count--) { /* Reset default mapping */ - rte_service_map_lcore_set(service_id, - slcore_array[slcore_count], 0); + if (rte_service_map_lcore_set(service_id, + slcore_array[slcore_count], 0) != 0) + return -ENOENT; service_count = rte_service_lcore_count_services( slcore_array[slcore_count]); if (service_count < min_service_count) { @@ -50,7 +51,7 @@ l2fwd_event_service_enable(uint32_t service_id) min_service_count = service_count; } } - if (rte_service_map_lcore_set(service_id, slcore, 1)) + if (rte_service_map_lcore_set(service_id, slcore, 1) != 0) return -ENOENT; rte_service_lcore_start(slcore); diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c index 142c00e8f..89a6bb9a4 100644 --- a/examples/l2fwd-event/main.c +++ b/examples/l2fwd-event/main.c @@ -234,6 +234,7 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, uint16_t port_id; uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; + int ret; printf("\nChecking link status..."); fflush(stdout); @@ -247,7 +248,14 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, if ((port_mask & (1 << port_id)) == 0) continue; memset(&link, 0, sizeof(link)); - rte_eth_link_get_nowait(port_id, &link); + ret = rte_eth_link_get_nowait(port_id, &link); + if (ret < 0) { + all_ports_up = 0; + if (print_flag == 1) + printf("Port %u link get failed: %s\n", + port_id, rte_strerror(-ret)); + continue; + } /* print link status if flag set */ if (print_flag == 1) { if (link.link_status) -- 2.17.1