From: "Wei Hu (Xavier)" <xavier.huwei@tom.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, xavier_huwei@163.com, xavier.huwei@tom.com,
huwei87@hisilicon.com
Subject: [dpdk-dev] [PATCH 1/6] net/hns3: fix RSS hardware configuration restore failure
Date: Fri, 22 Nov 2019 20:39:49 +0800 [thread overview]
Message-ID: <20191122123954.17911-2-xavier.huwei@tom.com> (raw)
In-Reply-To: <20191122123954.17911-1-xavier.huwei@tom.com>
From: Hao Chen <chenhao164@huawei.com>
This patch fixes the bug that hardware configuration called
tc_size doesn't restore to the initial value when starting
the app, configuring PFC and then restarting the app,
because of the tc_mode didn't initial when rss is disabled.
Fixes: c37ca66f2b27 ("net/hns3: support RSS")
Cc: stable@dpdk.org
Signed-off-by: Hao Chen <chenhao164@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
---
| 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c
index 6a5d63398..b8c20e6d9 100644
--- a/drivers/net/hns3/hns3_rss.c
+++ b/drivers/net/hns3/hns3_rss.c
@@ -525,10 +525,8 @@ hns3_config_rss(struct hns3_adapter *hns)
enum rte_eth_rx_mq_mode mq_mode = hw->data->dev_conf.rxmode.mq_mode;
/* When there is no open RSS, redirect the packet queue 0 */
- if (((uint32_t)mq_mode & ETH_MQ_RX_RSS_FLAG) == 0) {
+ if (((uint32_t)mq_mode & ETH_MQ_RX_RSS_FLAG) == 0)
hns3_rss_uninit(hns);
- return 0;
- }
/* Configure RSS hash algorithm and hash key offset */
ret = hns3_set_rss_algo_key(hw, hash_algo, hash_key);
--
2.23.0
next prev parent reply other threads:[~2019-11-22 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 12:39 [dpdk-dev] [PATCH 0/6] Fixes for hns3 PMD driver Wei Hu (Xavier)
2019-11-22 12:39 ` Wei Hu (Xavier) [this message]
2019-11-22 12:39 ` [dpdk-dev] [PATCH 2/6] net/hns3: fix VF configuration table entries restore failure Wei Hu (Xavier)
-- strict thread matches above, loose matches on Subject: below --
2019-11-22 12:06 [dpdk-dev] [PATCH 0/6] Fixes for hns3 PMD driver Wei Hu (Xavier)
2019-11-22 12:06 ` [dpdk-dev] [PATCH 1/6] net/hns3: fix RSS hardware configuration restore failure Wei Hu (Xavier)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122123954.17911-2-xavier.huwei@tom.com \
--to=xavier.huwei@tom.com \
--cc=dev@dpdk.org \
--cc=huwei87@hisilicon.com \
--cc=stable@dpdk.org \
--cc=xavier_huwei@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).