DPDK patches and discussions
 help / color / mirror / Atom feed
From: Vadim <podovinnikov@protei.ru>
To: chas3@att.com
Cc: dev@dpdk.org, podovinnikov <podovinnikov@protei.ru>
Subject: [dpdk-dev] [PATCH] fix lacp check system address
Date: Mon, 25 Nov 2019 16:13:26 +0300	[thread overview]
Message-ID: <20191125131326.28111-1-podovinnikov@protei.ru> (raw)

From: podovinnikov <podovinnikov@protei.ru>

---
 drivers/net/bonding/rte_eth_bond_8023ad.c | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index b77a37ddb..132ff74a1 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -792,18 +792,38 @@ rx_machine_update(struct bond_dev_private *internals, uint16_t slave_id,
 		struct rte_mbuf *lacp_pkt) {
 	struct lacpdu_header *lacp;
 	struct lacpdu_actor_partner_params *partner;
+	struct port *port, *agg;
 
 	if (lacp_pkt != NULL) {
 		lacp = rte_pktmbuf_mtod(lacp_pkt, struct lacpdu_header *);
 		RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP);
 
 		partner = &lacp->lacpdu.partner;
+		port = &bond_mode_8023ad_ports[slave_id];
+		agg = &bond_mode_8023ad_ports[port->aggregator_port_id];
+
 		if (rte_is_same_ether_addr(&partner->port_params.system,
-			&internals->mode4.mac_addr)) {
+									&agg->actor.system)) {
 			/* This LACP frame is sending to the bonding port
 			 * so pass it to rx_machine.
 			 */
 			rx_machine(internals, slave_id, &lacp->lacpdu);
+		} else {
+			MODE4_DEBUG("prefered partner system %02x:%02x:%02x:%02x:%02x:%02x "
+				"not equal self system: %02x:%02x:%02x:%02x:%02x:%02x\n",
+			partner->port_params.system.addr_bytes[0],
+			partner->port_params.system.addr_bytes[1],
+			partner->port_params.system.addr_bytes[2],
+			partner->port_params.system.addr_bytes[3],
+			partner->port_params.system.addr_bytes[4],
+			partner->port_params.system.addr_bytes[5],
+
+			agg->actor.system.addr_bytes[0],
+			agg->actor.system.addr_bytes[1],
+			agg->actor.system.addr_bytes[2],
+			agg->actor.system.addr_bytes[3],
+			agg->actor.system.addr_bytes[4],
+			agg->actor.system.addr_bytes[5]);
 		}
 		rte_pktmbuf_free(lacp_pkt);
 	} else
-- 
2.17.1


             reply	other threads:[~2019-11-25 18:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 13:13 Vadim [this message]
2019-11-25 22:25 ` Stephen Hemminger
2019-11-26 11:45   ` [dpdk-dev] [PATCH v2] " Vadim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191125131326.28111-1-podovinnikov@protei.ru \
    --to=podovinnikov@protei.ru \
    --cc=chas3@att.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).