From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02BD0A04C2; Mon, 25 Nov 2019 14:26:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F13A22952; Mon, 25 Nov 2019 14:26:46 +0100 (CET) Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 14B1328EE; Mon, 25 Nov 2019 14:26:45 +0100 (CET) Received: from 2606-a000-111b-43ee-0000-0000-0000-115f.inf6.spectrum.com ([2606:a000:111b:43ee::115f] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1iZENm-0006YN-BV; Mon, 25 Nov 2019 08:26:37 -0500 Date: Mon, 25 Nov 2019 08:26:20 -0500 From: Neil Horman To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, arybchenko@solarflare.com, stable@dpdk.org Message-ID: <20191125132620.GB14928@hmswarspite.think-freely.org> References: <20191125081007.12396-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191125081007.12396-1-david.marchand@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH 1/2] buildtools: fix experimental symbols listing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 25, 2019 at 09:10:06AM +0100, David Marchand wrote: > The map-list-symbol.sh script displays the filename, section and symbol > names of map files. > > Example: > $ buildtools/map-list-symbol.sh -S EXPERIMENTAL \ > lib/librte_ethdev/rte_ethdev_version.map |grep rte_mtr_create > lib/librte_ethdev/rte_ethdev_version.map EXPERIMENTAL rte_mtr_create > > The experimental symbol check should only consider the symbol name. > > Fixes: 3290ac14eb94 ("buildtools: detect discrepancies for experimental symbols") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > buildtools/check-experimental-syms.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh > index 145dd70ebf..abebb89f12 100755 > --- a/buildtools/check-experimental-syms.sh > +++ b/buildtools/check-experimental-syms.sh > @@ -23,7 +23,7 @@ trap 'rm -f "$DUMPFILE"' EXIT > objdump -t $OBJFILE >$DUMPFILE > > ret=0 > -for SYM in `$LIST_SYMBOL -S EXPERIMENTAL $MAPFILE` > +for SYM in `$LIST_SYMBOL -S EXPERIMENTAL $MAPFILE |cut -d ' ' -f 3` > do > if grep -q "\.text.*$SYM$" $DUMPFILE && > ! grep -q "\.text\.experimental.*$SYM$" $DUMPFILE > -- > 2.23.0 > > Series Acked-by: Neil Horman