From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80857A034F; Mon, 25 Nov 2019 23:25:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B5DC28EE; Mon, 25 Nov 2019 23:25:29 +0100 (CET) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 18A78CF3 for ; Mon, 25 Nov 2019 23:25:27 +0100 (CET) Received: by mail-pg1-f194.google.com with SMTP id k13so7922984pgh.3 for ; Mon, 25 Nov 2019 14:25:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v9p4vymyLzrbUCKc4dk6s4Z4hCr3dXa72XtxaZfXiFs=; b=XgZxru9M40aRH+atz61Zf9Vc93Be7Q82UDqRTHv3OPXJNlijnLKpazeJDNJj3r1TWK wIx9tZoQVr6KfIwLpzipsPcZ61ogilcTdtHeiCuNcsKi4zDqVqP4cZ0YeZlCn2FQqdNQ N9klx4oe/zUnNnfUiXREbbV23L55c3z/sEYfM+SN46DHOe+TF8iZrzPzFmhKysC2ABz7 sYjatjyfu1hvAV7ABUDLjGIdxpXbkfRutrt/SE25Pw7HIKLHKi41yKgAhilHzsoAaKyh ognuVIecMpCuaguSxNTSc944kQ2DWWxbvx5OEUTsDcjngeBKpiL/UAdmCLjIUoYeGri0 8Ugw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v9p4vymyLzrbUCKc4dk6s4Z4hCr3dXa72XtxaZfXiFs=; b=rT6wIgQ5i4uiRKTWNk66HVdDTx8pJyPjpd9URzrT1fMbMDk7rOQt7Sv2stwZb/8rM9 utSz9vRR08RGK7nD7TQp0PUvz/RFuO9lYPtEQAL/CM2n5bY17WZRFOhNbcM9jcFHC5QE DFUvTjS1v498x9N8IVTM83r3E8ZCzMNf9FlIVWM1Rm2qNYxg2YSHSjrp99847JYSc/rh K2OQgU/4JDOW4XTmVgLow8oP4szeZxoxKGQPHZggZxpopApAwrJjA+9mJXcXlJLXPOWA p0iWSLxLsnBl3mkAirdTigBOjkhMbK4ONi+2ZNFLnW7BEWDCz+0vpx6SKNGXxg+XY4X5 /Ulg== X-Gm-Message-State: APjAAAV+FGHEkhcVr1bB8npbvn3JagAwtNQ0RkOqfgC8kjfR8LxPQOfy DZ/3KuONaaBehD6ZOBw4ltk2dndxojwWsg== X-Google-Smtp-Source: APXvYqx+ngnkoXcbYnd69x+YumEYv6wrgmweAehF1u9vONtdHD95QSwjWhWG8+gXzME0yR3VeWZkJQ== X-Received: by 2002:a62:7b0e:: with SMTP id w14mr37373866pfc.177.1574720726915; Mon, 25 Nov 2019 14:25:26 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id v63sm9677366pfb.181.2019.11.25.14.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2019 14:25:26 -0800 (PST) Date: Mon, 25 Nov 2019 14:25:18 -0800 From: Stephen Hemminger To: Vadim Cc: chas3@att.com, dev@dpdk.org Message-ID: <20191125142518.5ae33d1e@hermes.lan> In-Reply-To: <20191125131326.28111-1-podovinnikov@protei.ru> References: <20191125131326.28111-1-podovinnikov@protei.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] fix lacp check system address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 25 Nov 2019 16:13:26 +0300 Vadim wrote: > + MODE4_DEBUG("prefered partner system %02x:%02x:%02x:%02x:%02x:%02x " > + "not equal self system: %02x:%02x:%02x:%02x:%02x:%02x\n", > + partner->port_params.system.addr_bytes[0], > + partner->port_params.system.addr_bytes[1], > + partner->port_params.system.addr_bytes[2], > + partner->port_params.system.addr_bytes[3], > + partner->port_params.system.addr_bytes[4], > + partner->port_params.system.addr_bytes[5], > + > + agg->actor.system.addr_bytes[0], > + agg->actor.system.addr_bytes[1], > + agg->actor.system.addr_bytes[2], > + agg->actor.system.addr_bytes[3], > + agg->actor.system.addr_bytes[4], > + agg->actor.system.addr_bytes[5]); Why not use rte_ether_format_addr instead?