From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D047A04C2; Mon, 25 Nov 2019 18:13:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 03F8D37A2; Mon, 25 Nov 2019 18:13:11 +0100 (CET) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id DB0B6CF3 for ; Mon, 25 Nov 2019 18:13:09 +0100 (CET) Received: by mail-pg1-f194.google.com with SMTP id z188so7504523pgb.1 for ; Mon, 25 Nov 2019 09:13:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nSfs3iItzzKiHmtUGOXaCqhbgRt/mYquruY5H93yJvQ=; b=GRIfANN233pqzxslyPVqpglnElUaeHM0hnphR8JCRu5coTJ2QjuQWbjbYwaXiz7O/a KgtW8s7+9s3wK/iXKHHAcUzanoVJSg4FGe9iW43KXBfgW/yfftKUIdAu/GNrDiMFx1Ev pJU/khneJwKa+8DwnSFfuYaIEN4vrR222VdvINxWQ5WxlMD7Of+DxJMFvkqJwDTmIpvm eOKgzgJO6HZA21zdKhGXwgXBtQF712H7TMM+QEjyxdvq7lwR5nNZ3T1kKdIdBNgePxcK Uh0wmIUhz8rwH1MBhDr7qQL6CKlUl1CRgGXNdO7s1CXK8tzEKEtKHEoc05voswlKMXCO BcOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nSfs3iItzzKiHmtUGOXaCqhbgRt/mYquruY5H93yJvQ=; b=M6iQNhv9r6/Q/tkBEgH+ggzeVMkKWde9ufulm2Y5uSB7E8M3bQfvK/CQ4UZ4tXQbYa 4QLJqcfT/+gVgsKmHEmBHRWZWA8NZMZZP69QD0ODB9HshlxIdASe2o+BfKbMbrak+NgD KjTgvQl8I9KZGixSkQNRzfEjQaBDcyn5c4VT3gWrkJ2BIuPuREljPF5nJHK5Eqs+flXR Rne18HTs8gQ922iABv7tjBwZYk4I8q/SdX+2GS53VXIc6WE7JH25Yg1rOzHXiApPos6C RHqj/DO/7U+qig7Fw+z8l8MQjFdqaIBF92CKXLB5As4vqUuDnxKM0l0pdmoEExQpDQVh rOLA== X-Gm-Message-State: APjAAAVEDWN6bKL7ZeKE59MCepFgzkEwiOKNCetUspmXzfmfUy7TGsyW QF7Q+CwRSWExF7saUU3fOJXjjPGDIOKBwQ== X-Google-Smtp-Source: APXvYqzvUe/522SA67PQZCAShepLXwGmubzYv7zGSiFUhL0zEzI2YOWB4lmbdffdpOpciBflSh78lw== X-Received: by 2002:a62:f243:: with SMTP id y3mr36049260pfl.196.1574701988550; Mon, 25 Nov 2019 09:13:08 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id v26sm9253414pfm.126.2019.11.25.09.13.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2019 09:13:07 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Dexuan Cui Date: Mon, 25 Nov 2019 09:13:00 -0800 Message-Id: <20191125171300.3284-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In order to change RSS parameters, the host requires that RSS is disable first. Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") Cc: stable@dpdk.org Signed-off-by: Dexuan Cui Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 164e9ad174a7..575780ee5f26 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev, hv->rss_ind[i] = reta_conf[idx].reta[shift]; } + err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); + if (err) { + PMD_DRV_LOG(NOTICE, + "rss disable failed"); + return err; + } + err = hn_rndis_conf_rss(hv, 0); if (err) { PMD_DRV_LOG(NOTICE, @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev) return err; } + err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); + if (err) { + PMD_DRV_LOG(NOTICE, + "rss disable failed"); + return err; + } + err = hn_rndis_conf_rss(hv, 0); if (err) { PMD_DRV_LOG(NOTICE, -- 2.20.1