From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C8BAA04C7; Tue, 26 Nov 2019 03:31:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 622322952; Tue, 26 Nov 2019 03:31:14 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id EC2CA91; Tue, 26 Nov 2019 03:31:12 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Nov 2019 18:31:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,244,1571727600"; d="scan'208";a="383011465" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga005.jf.intel.com with ESMTP; 25 Nov 2019 18:31:10 -0800 Date: Tue, 26 Nov 2019 10:27:21 +0800 From: Ye Xiaolong To: "Lu, Wenzhuo" Cc: "Cui, LunyuanX" , "dev@dpdk.org" , "stable@dpdk.org" Message-ID: <20191126022721.GE101220@intel.com> References: <20191118101345.42181-1-lunyuanx.cui@intel.com> <20191118153744.78987-1-lunyuanx.cui@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC0909408A3B6E@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909408A3B6E@shsmsx102.ccr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/26, Lu, Wenzhuo wrote: >Hi, > > >> -----Original Message----- >> From: Cui, LunyuanX >> Sent: Monday, November 18, 2019 11:38 PM >> To: dev@dpdk.org >> Cc: Lu, Wenzhuo ; Cui, LunyuanX >> ; stable@dpdk.org >> Subject: [PATCH v4] net/ixgbe: fix link status >> >> The link status for 82599eb got from link status register was not correct. >> Check the enable/disable flag of tx laser, set the link status down if tx laser >> disabled. Then, we can get correct status. >> But after port reset, tx laser register will be reset enable. >> Link status will always be up. So set tx laser disable when port resets. >> >> When hw->mac.autotry_restart is true, whether tx laser is disable or enable, >> it will be set enable in ixgbe_flap_tx_laser_multispeed_fiber(). >> hw->mac.autotry_restart can be set true in both port init and port start. >> Because we don't need this treatment before port starts, set >> hw->mac.autotry_restart false when port init. >> >> Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update") >> Cc: stable@dpdk.org >> >> Signed-off-by: Lunyuan Cui >Acked-by: Wenzhuo Lu Applied to dpdk-next-net-intel, Thanks.