From: Ali Alnubani <alialnu@mellanox.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH] net/mlx5: fix build with dlopen linkage
Date: Tue, 26 Nov 2019 08:35:24 +0000 [thread overview]
Message-ID: <20191126083503.23498-1-alialnu@mellanox.com> (raw)
The header mlx5_glue.h includes rte_byteorder.h, which isn't
pulled by global_inc. This patch adds the missing include directory
and fixes the build error:
In file included from drivers/net/mlx5/mlx5_glue.c:31:
drivers/net/mlx5/mlx5_glue.h:12:10: fatal error:
rte_byteorder.h: No such file or directory
The build failure can be triggered with:
meson -Dibverbs_link=dlopen build && ninja -C build
Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue")
Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
drivers/net/mlx5/meson.build | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index 05fadf608..d6b32db79 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -206,10 +206,14 @@ if pmd_dlopen and build
dlopen_so_version = LIB_GLUE_VERSION
dlopen_sources = files('mlx5_glue.c')
dlopen_install_dir = [ eal_pmd_path + '-glue' ]
+ dlopen_includes = [global_inc]
+ dlopen_includes += include_directories(
+ '../../../lib/librte_eal/common/include/generic',
+ )
shared_lib = shared_library(
dlopen_lib_name,
dlopen_sources,
- include_directories: global_inc,
+ include_directories: dlopen_includes,
c_args: cflags,
dependencies: libs,
link_args: [
--
2.24.0
next reply other threads:[~2019-11-26 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 8:35 Ali Alnubani [this message]
2019-11-26 14:53 ` Thomas Monjalon
2019-11-26 15:14 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126083503.23498-1-alialnu@mellanox.com \
--to=alialnu@mellanox.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).