[dpdk-dev] [PATCH] net/mlx5: fix build with dlopen linkage

[dpdk-dev] [PATCH] net/mlx5: fix build with dlopen linkage

[Ali Alnubani]

The header mlx5_glue.h includes rte_byteorder.h, which isn't
pulled by global_inc. This patch adds the missing include directory
and fixes the build error:

  In file included from drivers/net/mlx5/mlx5_glue.c:31:
  drivers/net/mlx5/mlx5_glue.h:12:10: fatal error:
  rte_byteorder.h: No such file or directory

The build failure can be triggered with:
  meson -Dibverbs_link=dlopen build && ninja -C build

Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue")

Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
 drivers/net/mlx5/meson.build | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index 05fadf608..d6b32db79 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -206,10 +206,14 @@ if pmd_dlopen and build
 	dlopen_so_version = LIB_GLUE_VERSION
 	dlopen_sources = files('mlx5_glue.c')
 	dlopen_install_dir = [ eal_pmd_path + '-glue' ]
+	dlopen_includes = [global_inc]
+	dlopen_includes += include_directories(
+		'../../../lib/librte_eal/common/include/generic',
+	)
 	shared_lib = shared_library(
 		dlopen_lib_name,
 		dlopen_sources,
-		include_directories: global_inc,
+		include_directories: dlopen_includes,
 		c_args: cflags,
 		dependencies: libs,
 		link_args: [
-- 
2.24.0

Re: [dpdk-dev] [PATCH] net/mlx5: fix build with dlopen linkage

[Thomas Monjalon]

26/11/2019 09:35, Ali Alnubani:
> The header mlx5_glue.h includes rte_byteorder.h, which isn't
> pulled by global_inc. This patch adds the missing include directory
> and fixes the build error:
> 
>   In file included from drivers/net/mlx5/mlx5_glue.c:31:
>   drivers/net/mlx5/mlx5_glue.h:12:10: fatal error:
>   rte_byteorder.h: No such file or directory
> 
> The build failure can be triggered with:
>   meson -Dibverbs_link=dlopen build && ninja -C build
> 
> Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue")
> 
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Re: [dpdk-dev] [PATCH] net/mlx5: fix build with dlopen linkage

[Raslan Darawsheh]

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ali Alnubani
> Sent: Tuesday, November 26, 2019 10:35 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix build with dlopen linkage
> 
> The header mlx5_glue.h includes rte_byteorder.h, which isn't
> pulled by global_inc. This patch adds the missing include directory
> and fixes the build error:
> 
>   In file included from drivers/net/mlx5/mlx5_glue.c:31:
>   drivers/net/mlx5/mlx5_glue.h:12:10: fatal error:
>   rte_byteorder.h: No such file or directory
> 
> The build failure can be triggered with:
>   meson -Dibverbs_link=dlopen build && ninja -C build
> 
> Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to
> glue")
> 
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> ---
>  drivers/net/mlx5/meson.build | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
> index 05fadf608..d6b32db79 100644
> --- a/drivers/net/mlx5/meson.build
> +++ b/drivers/net/mlx5/meson.build
> @@ -206,10 +206,14 @@ if pmd_dlopen and build
>  	dlopen_so_version = LIB_GLUE_VERSION
>  	dlopen_sources = files('mlx5_glue.c')
>  	dlopen_install_dir = [ eal_pmd_path + '-glue' ]
> +	dlopen_includes = [global_inc]
> +	dlopen_includes += include_directories(
> +		'../../../lib/librte_eal/common/include/generic',
> +	)
>  	shared_lib = shared_library(
>  		dlopen_lib_name,
>  		dlopen_sources,
> -		include_directories: global_inc,
> +		include_directories: dlopen_includes,
>  		c_args: cflags,
>  		dependencies: libs,
>  		link_args: [
> --
> 2.24.0


Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh