From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51605A04DD; Tue, 26 Nov 2019 14:25:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E9E5F2A5D; Tue, 26 Nov 2019 14:25:52 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 50C24CF3; Tue, 26 Nov 2019 14:25:51 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2019 05:25:49 -0800 X-IronPort-AV: E=Sophos;i="5.69,245,1571727600"; d="scan'208";a="198821546" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 26 Nov 2019 05:25:48 -0800 Date: Tue, 26 Nov 2019 13:25:45 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: Ali Alnubani , "dev@dpdk.org" , "stable@dpdk.org" Message-ID: <20191126132545.GC1629@bricha3-MOBL.ger.corp.intel.com> References: <20191126081637.23008-1-alialnu@mellanox.com> <20191126105028.24948-1-alialnu@mellanox.com> <3358503.0YUIpihZ7K@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3358503.0YUIpihZ7K@xps> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v2] eal: fix header files install with meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 26, 2019 at 12:17:41PM +0100, Thomas Monjalon wrote: > 26/11/2019 11:51, Ali Alnubani: > > The following header files weren't being installed by meson: > > - rte_vfio.h > > - rte_function_versioning.h > > - rte_test.h > > > > This patch adds them to the common_headers list so that > > they are installed. > > > > Fixes: 610beca42ea4 ("build: remove library special cases") > > I am not sure this is the right root cause. > At least for rte_function_versioning.h, it has been added recently. > Thanks for pointing this out. The rte_function_versioning.h file I deliberately omitted from the meson install since it's really for internal use only. It's not really recommended for external app use, since it relies on some DPDK defines etc. > > Cc: bruce.richardson@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Ali Alnubani > > Reviewed-by: Thomas Monjalon > > Acked-by: Bruce Richardson > > >