DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>,
	david.marchand@redhat.com, ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] devtools: control location of test builds
Date: Thu, 28 Nov 2019 09:48:32 +0000	[thread overview]
Message-ID: <20191128094832.GA2381@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20191127230055.23608-1-thomas@monjalon.net>

On Thu, Nov 28, 2019 at 12:00:55AM +0100, Thomas Monjalon wrote:
> From: Bruce Richardson <bruce.richardson@intel.com>
> 
> By default, both test-build.sh and test-meson-builds.sh scripts create the
> builds they generate in the current working directory, leading to a large
> number of build directories being present when testing patches. This
> patchset modifies both scripts to use a DPDK_BUILD_TEST_DIR environment
> variable to control where the build outputs are put.
> 
> For example, doing:
>     export DPDK_BUILD_TEST_DIR=__builds
>     ./devtools/test-meson-builds.sh && ./devtools/test-build.sh \
>             x86_64-native-linux-clang+shared i686-native-linux-gcc
> 
> gives a "__builds" directory with 14 meson and 2 make builds (with the
> meson build count depending on compiler availability)
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2:
> - rename DPDK_TEST_BUILD_DIR to DPDK_BUILD_TEST_DIR
> - add comment in devtools/test-build.sh and its guide section
> - load from config file in test-meson-builds.sh
> ---

Thanks for the update, those seem ok changes to me. The doc one I should
have caught in the V1, so it's especially welcome.

/Bruce


  reply	other threads:[~2019-11-28  9:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-09 10:10 [dpdk-dev] [PATCH] " Bruce Richardson
2019-11-27 23:00 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2019-11-28  9:48   ` Bruce Richardson [this message]
2019-11-28 11:47   ` Trahe, Fiona
2019-11-28 13:20     ` Thomas Monjalon
2019-11-28 18:40   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191128094832.GA2381@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).