From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8CCDA04E0; Thu, 28 Nov 2019 10:48:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E209B2B88; Thu, 28 Nov 2019 10:48:39 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C379D29CB for ; Thu, 28 Nov 2019 10:48:38 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 01:48:37 -0800 X-IronPort-AV: E=Sophos;i="5.69,253,1571727600"; d="scan'208";a="203385959" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 28 Nov 2019 01:48:35 -0800 Date: Thu, 28 Nov 2019 09:48:32 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: John McNamara , Marko Kovacevic , david.marchand@redhat.com, ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20191128094832.GA2381@bricha3-MOBL.ger.corp.intel.com> References: <20191009101026.49019-1-bruce.richardson@intel.com> <20191127230055.23608-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191127230055.23608-1-thomas@monjalon.net> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v2] devtools: control location of test builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 28, 2019 at 12:00:55AM +0100, Thomas Monjalon wrote: > From: Bruce Richardson > > By default, both test-build.sh and test-meson-builds.sh scripts create the > builds they generate in the current working directory, leading to a large > number of build directories being present when testing patches. This > patchset modifies both scripts to use a DPDK_BUILD_TEST_DIR environment > variable to control where the build outputs are put. > > For example, doing: > export DPDK_BUILD_TEST_DIR=__builds > ./devtools/test-meson-builds.sh && ./devtools/test-build.sh \ > x86_64-native-linux-clang+shared i686-native-linux-gcc > > gives a "__builds" directory with 14 meson and 2 make builds (with the > meson build count depending on compiler availability) > > Signed-off-by: Bruce Richardson > Signed-off-by: Thomas Monjalon > --- > v2: > - rename DPDK_TEST_BUILD_DIR to DPDK_BUILD_TEST_DIR > - add comment in devtools/test-build.sh and its guide section > - load from config file in test-meson-builds.sh > --- Thanks for the update, those seem ok changes to me. The doc one I should have caught in the V1, so it's especially welcome. /Bruce