patch checks the return value of function rte_eth_dev_info_get, if return value is negative error message printed on the console. Coverity issue: 350361 Signed-off-by: Praveen Shetty <praveen.shetty@intel.com> --- examples/ioat/ioatfwd.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index e9117718f..b39a098ec 100644 --- a/examples/ioat/ioatfwd.c +++ b/examples/ioat/ioatfwd.c @@ -824,7 +824,11 @@ port_init(uint16_t portid, struct rte_mempool *mbuf_pool, uint16_t nb_queues) /* Init port */ printf("Initializing port %u... ", portid); fflush(stdout); - rte_eth_dev_info_get(portid, &dev_info); + ret = rte_eth_dev_info_get(portid, &dev_info); + if (ret < 0) + rte_exit(EXIT_FAILURE, "Cannot get device info: %s, port=%u\n", + rte_strerror(-ret), portid); + local_port_conf.rx_adv_conf.rss_conf.rss_hf &= dev_info.flow_type_rss_offloads; if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) -- 2.17.1
patch checks the return value of function rte_eth_dev_info_get, if return value is negative error message printed on the console. Coverity issue: 350361 Signed-off-by: Praveen Shetty <praveen.shetty@intel.com> --- examples/ioat/ioatfwd.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index e9117718f..b39a098ec 100644 --- a/examples/ioat/ioatfwd.c +++ b/examples/ioat/ioatfwd.c @@ -824,7 +824,11 @@ port_init(uint16_t portid, struct rte_mempool *mbuf_pool, uint16_t nb_queues) /* Init port */ printf("Initializing port %u... ", portid); fflush(stdout); - rte_eth_dev_info_get(portid, &dev_info); + ret = rte_eth_dev_info_get(portid, &dev_info); + if (ret < 0) + rte_exit(EXIT_FAILURE, "Cannot get device info: %s, port=%u\n", + rte_strerror(-ret), portid); + local_port_conf.rx_adv_conf.rss_conf.rss_hf &= dev_info.flow_type_rss_offloads; if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) -- 2.17.1
patch checks the return value of function rte_eth_dev_info_get, if return value is negative error message printed on the console. Coverity issue: 350361 Fixes: c8e6ceecebc1 ("examples/ioat: add new sample app for ioat driver") Cc: pawelx.modrak@intel.com Signed-off-by: Praveen Shetty <praveen.shetty@intel.com> --- examples/ioat/ioatfwd.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index e9117718f..b39a098ec 100644 --- a/examples/ioat/ioatfwd.c +++ b/examples/ioat/ioatfwd.c @@ -824,7 +824,11 @@ port_init(uint16_t portid, struct rte_mempool *mbuf_pool, uint16_t nb_queues) /* Init port */ printf("Initializing port %u... ", portid); fflush(stdout); - rte_eth_dev_info_get(portid, &dev_info); + ret = rte_eth_dev_info_get(portid, &dev_info); + if (ret < 0) + rte_exit(EXIT_FAILURE, "Cannot get device info: %s, port=%u\n", + rte_strerror(-ret), portid); + local_port_conf.rx_adv_conf.rss_conf.rss_hf &= dev_info.flow_type_rss_offloads; if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) -- 2.17.1
On Thu, Nov 28, 2019 at 11:27:14AM +0000, Praveen Shetty wrote:
> patch checks the return value of function rte_eth_dev_info_get,
> if return value is negative error message printed on the console.
>
> Coverity issue: 350361
> Fixes: c8e6ceecebc1 ("examples/ioat: add new sample app for ioat driver")
> Cc: pawelx.modrak@intel.com
>
> Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
> ---
> examples/ioat/ioatfwd.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thanks for the fix.
This is non-critical so merge can be deferred to 20.02
On Thu, Nov 28, 2019 at 12:32 PM Bruce Richardson <bruce.richardson@intel.com> wrote: > > On Thu, Nov 28, 2019 at 11:27:14AM +0000, Praveen Shetty wrote: > > patch checks the return value of function rte_eth_dev_info_get, > > if return value is negative error message printed on the console. > > > > Coverity issue: 350361 > > Fixes: c8e6ceecebc1 ("examples/ioat: add new sample app for ioat driver") Cc: stable@dpdk.org > > > > Signed-off-by: Praveen Shetty <praveen.shetty@intel.com> > > --- > > examples/ioat/ioatfwd.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > Acked-by: Bruce Richardson <bruce.richardson@intel.com> Applied, thanks. -- David Marchand