From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, john.mcnamara@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/8] doc: update Linux GSG system requirements section
Date: Thu, 28 Nov 2019 14:30:08 +0000 [thread overview]
Message-ID: <20191128143008.GC2386@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <2316895.6DYn9dXaqE@xps>
On Thu, Nov 28, 2019 at 03:22:05PM +0100, Thomas Monjalon wrote:
> 28/11/2019 15:11, Bruce Richardson:
> > On Thu, Nov 28, 2019 at 12:51:27PM +0100, Thomas Monjalon wrote:
> > > 22/11/2019 17:03, Bruce Richardson:
> > > [...]
> > > > -* GNU ``make``.
> > > > +* General development tools including ``make``, and a supported C compiler such as ``gcc`` or ``clang``.
> > >
> > > Why referring to make and not meson?
> >
> > Because even with meson build we still use make for building kernel
> > modules, and this first bullet item is all about getting the basic build
> > packages which come from build-essential etc. Make is part of that build
> > tools group on distros, meson and ninja are not.
>
> OK
>
> > > > -* gcc: versions 4.9 or later is recommended for all platforms.
> > > > - On some distributions, some specific compiler flags and linker flags are enabled by
> > > > - default and affect performance (``-fstack-protector``, for example). Please refer to the documentation
> > > > - of your distribution and to ``gcc -dumpspecs``.
> > >
> > > I think we need to keep some compiler requirement somewhere.
> > > What do you suggest?
> >
> > I'm happy to keep this compiler requirements in here. Is 4.9 still
> > regularly tested with DPDK to ensure it works? Also, if we put in a GCC
> > requirement, do we not also need to put in a clang one? For recent distros
> > is this really something most users need to worry about?
>
> It allows us to know which compiler we must support.
> And for distributions, it can help.
> I think we should have clang version too.
>
Ok, I'll add 4.9 recommendation in V2. If we have a minimum clang version
you want included, I can add that too, if someone gets it to me in time :-)
<snip>
> > > > +* Meson (v0.47.1+) and ninja
> > > >
> > > > + * Recommended to use the latest versions from Python's "pip" repository:
> > > > + ``pip3 install meson ninja``
> > >
> > > Why recommending pip? Is 0.47.1 enough?
> >
> > It is enough, this was done again in the interests of simplification -
> > rather than worry about what versions are in what distro and having the
> > user check, it simplifies things if everyone just uses pip, which is why I
> > recommend it.
>
> I think we should let users take the responsibility of using their distro
> package or pip.
> Recommending pip is a little pushy.
>
Ok, will add possibility of using distro packages in V2.
<snip>
next prev parent reply other threads:[~2019-11-28 14:30 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 16:03 [dpdk-dev] [PATCH 0/8] GSG Documentation updates Bruce Richardson
2019-11-22 16:03 ` [dpdk-dev] [PATCH 1/8] doc: update Linux GSG system requirements section Bruce Richardson
2019-11-28 11:51 ` Thomas Monjalon
2019-11-28 14:11 ` Bruce Richardson
2019-11-28 14:22 ` Thomas Monjalon
2019-11-28 14:30 ` Bruce Richardson [this message]
2019-11-28 14:34 ` Thomas Monjalon
2019-11-28 14:59 ` Bruce Richardson
2019-11-22 16:03 ` [dpdk-dev] [PATCH 2/8] doc: add building with meson to linux GSG Bruce Richardson
2019-11-25 13:19 ` Burakov, Anatoly
2019-11-25 13:27 ` Bruce Richardson
2019-11-25 13:54 ` Burakov, Anatoly
2019-11-25 14:40 ` Richardson, Bruce
2019-11-25 13:22 ` Burakov, Anatoly
2019-11-25 14:38 ` Richardson, Bruce
2019-11-22 16:03 ` [dpdk-dev] [PATCH 3/8] doc: reorder meson and make build instructions for arm Bruce Richardson
2019-11-24 11:25 ` Gavin Hu (Arm Technology China)
2019-11-22 16:03 ` [dpdk-dev] [PATCH 4/8] doc: remove reference to old versions of FreeBSD Bruce Richardson
2019-11-22 16:03 ` [dpdk-dev] [PATCH 5/8] doc: update examples output in FreeBSD GSG Bruce Richardson
2019-11-22 16:03 ` [dpdk-dev] [PATCH 6/8] doc: add meson install instructions for FreeBSD Bruce Richardson
2019-11-22 16:03 ` [dpdk-dev] [PATCH 7/8] doc: update documentation on build and running FreeBSD apps Bruce Richardson
2019-11-22 16:03 ` [dpdk-dev] [PATCH 8/8] doc: drop EAL command-line reference from FreeBSD GSG Bruce Richardson
2019-11-25 14:55 ` [dpdk-dev] [PATCH v2 0/8] GSG Documentation updates Bruce Richardson
2019-11-25 14:55 ` [dpdk-dev] [PATCH v2 1/8] doc: update Linux GSG system requirements section Bruce Richardson
2019-11-25 14:55 ` [dpdk-dev] [PATCH v2 2/8] doc: add building with meson to linux GSG Bruce Richardson
2019-11-25 15:11 ` Burakov, Anatoly
2019-11-25 14:55 ` [dpdk-dev] [PATCH v2 3/8] doc: reorder meson and make build instructions for arm Bruce Richardson
2019-11-25 14:55 ` [dpdk-dev] [PATCH v2 4/8] doc: remove reference to old versions of FreeBSD Bruce Richardson
2019-11-27 12:10 ` Burakov, Anatoly
2019-11-25 14:55 ` [dpdk-dev] [PATCH v2 5/8] doc: update examples output in FreeBSD GSG Bruce Richardson
2019-11-27 12:11 ` Burakov, Anatoly
2019-11-27 12:23 ` Bruce Richardson
2019-11-25 14:55 ` [dpdk-dev] [PATCH v2 6/8] doc: add meson install instructions for FreeBSD Bruce Richardson
2019-11-27 12:23 ` Burakov, Anatoly
2019-11-25 14:55 ` [dpdk-dev] [PATCH v2 7/8] doc: update documentation on build and running FreeBSD apps Bruce Richardson
2019-11-27 12:29 ` Burakov, Anatoly
2019-11-25 14:55 ` [dpdk-dev] [PATCH v2 8/8] doc: drop EAL command-line reference from FreeBSD GSG Bruce Richardson
2019-11-27 12:31 ` Burakov, Anatoly
2019-11-27 13:46 ` Bruce Richardson
2019-11-28 16:33 ` [dpdk-dev] [PATCH v3 0/5] GSG Documentation updates Bruce Richardson
2019-11-28 16:33 ` [dpdk-dev] [PATCH v3 1/5] doc: update Linux GSG system requirements section Bruce Richardson
2019-11-28 16:33 ` [dpdk-dev] [PATCH v3 2/5] doc: add building with meson to linux GSG Bruce Richardson
2019-11-28 16:33 ` [dpdk-dev] [PATCH v3 3/5] doc: reorder meson and make build instructions for arm Bruce Richardson
2019-11-28 16:33 ` [dpdk-dev] [PATCH v3 4/5] doc: remove reference to old versions of FreeBSD Bruce Richardson
2019-11-28 16:33 ` [dpdk-dev] [PATCH v3 5/5] doc: update examples output in FreeBSD GSG Bruce Richardson
2019-11-28 18:56 ` [dpdk-dev] [PATCH v3 0/5] GSG Documentation updates Thomas Monjalon
2020-01-03 15:37 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128143008.GC2386@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).