From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85B58A04B5; Tue, 3 Dec 2019 06:37:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E52EA4C93; Tue, 3 Dec 2019 06:37:31 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DEC6D37AF; Tue, 3 Dec 2019 06:37:29 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 21:37:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,272,1571727600"; d="scan'208";a="204845059" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga008.jf.intel.com with ESMTP; 02 Dec 2019 21:37:27 -0800 Date: Tue, 3 Dec 2019 13:33:19 +0800 From: Ye Xiaolong To: Bruce Richardson Cc: Igor Ryzhov , Ferruh Yigit , dev , dpdk stable Message-ID: <20191203053319.GA3210@intel.com> References: <20191202061442.56964-1-xiaolong.ye@intel.com> <20191202083903.GA78157@intel.com> <20191202113454.GB78157@intel.com> <20191202120819.GA25@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191202120819.GA25@bricha3-MOBL.ger.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/02, Bruce Richardson wrote: >On Mon, Dec 02, 2019 at 07:34:54PM +0800, Ye Xiaolong wrote: >> On 12/02, Igor Ryzhov wrote: >> >We should at least install it into /lib/modules/kernel-version. For >> >convenience, dpdk modules are installed into >> >/lib/modules/kernel-version/extra/dpdk. >> >In the cross-compilation case, you can use DEST_DIR to set some prefix. >> > >> >I don't really see the issue here. The description clearly says that >> >headers must be in $kernel_dir/build which is usually a symlink >> >to /usr/src/linux-headers-kernel-version. >> >Just set kernel_dir correctly and there won't be compilation failure. >> >> I think for cross-compilation case, user should be allowed to specify any kernel >> src dir (it doesn't have to be /lib/modules/kernel-version) in his local system >> as kernel_dir that doesn't contain the build dir, in this case, current meson >> build will skip kernel module compilation. >> > >I don't think we can take this change as the default, since the previous >fix was put in for good reason. > >However, perhaps we can attempt to support both, using the checks below for >"make kernelversion" in kernel/linux/meson.build. We can attempt using the >directory with /build (as now) and then if that fails attempt without it (or >vice versa). After a second thought, I think it'd be better that we unify the meaning of kernel_dir for both cases, it should be aligned with make's RTE_KERNELDIR variable that specify the directory contains kernel src code (or header), then we don't need to distinguish these 2 cases in check (make kernelversion) phase, we just need to assign different install dirs, For normal case: kernel_dir=/lib/modules//build install_dir=/lib/modules//extra/dpdk For cross compilation case: kernel_dir= install_dir=/extra/dpdk What do you think (I've sent v2 according to above description)? Thanks, Xiaolong > >/Bruce