From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E54F2A04B5; Tue, 3 Dec 2019 14:58:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 444312B8D; Tue, 3 Dec 2019 14:58:44 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1C914235; Tue, 3 Dec 2019 14:58:41 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 05:58:39 -0800 X-IronPort-AV: E=Sophos;i="5.69,273,1571727600"; d="scan'208";a="204982521" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 03 Dec 2019 05:58:38 -0800 Date: Tue, 3 Dec 2019 13:58:35 +0000 From: Bruce Richardson To: Ye Xiaolong Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org, iryzhov@nfware.com Message-ID: <20191203135835.GA45@bricha3-MOBL.ger.corp.intel.com> References: <20191202061442.56964-1-xiaolong.ye@intel.com> <20191203052917.19820-1-xiaolong.ye@intel.com> <20191203101140.GB38@bricha3-MOBL.ger.corp.intel.com> <20191203123322.GA22356@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191203123322.GA22356@intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v2] kernel/linux: fix kernel dir for meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Dec 03, 2019 at 08:33:22PM +0800, Ye Xiaolong wrote: > On 12/03, Bruce Richardson wrote: > >On Tue, Dec 03, 2019 at 01:29:17PM +0800, Xiaolong Ye wrote: > >> kernel_dir option in meson build is equivalent to RTE_KERNELDIR in make > >> system, for cross-compilation case, users would specify it as local > >> kernel src dir like > >> > >> //target-arm_glibc/linux-arm/linux-4.19.81/ > >> > >> Current meson build would fail to compile kernel module if user specify > >> kernel_dir as above, this patch fixes this issue. > >> > >> Fixes: 317832f97c16 ("kernel/linux: fix modules install path") > >> Cc: stable@dpdk.org > >> Cc: iryzhov@nfware.com > >> > >> Signed-off-by: Xiaolong Ye > >> --- > >> > >> V2 changes: > >> > >> 1. handle both normal and cross-compilation cases > >> > >We need to handle both, but they need to be handled without breaking the > >currently working case where we pass in /lib/modules/$(uname -r)/ as the > >kerneldir path. > > So you mean we should allow user to specify both /lib/modules/$(uname -r) and > /lib/modules/$(uname -r)/build as kernel_dir for normal case? > That is up to you, but we need to still allow the former case so as to avoid breaking backward compatibility for existing build setups. Therefore I suggest supporting both is recommended. /Bruce