From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64B89A04B5; Wed, 4 Dec 2019 11:46:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB37D1BE84; Wed, 4 Dec 2019 11:46:28 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id CADF01BE83 for ; Wed, 4 Dec 2019 11:46:26 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2019 02:46:25 -0800 X-IronPort-AV: E=Sophos;i="5.69,277,1571727600"; d="scan'208";a="385708207" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Dec 2019 02:46:23 -0800 Date: Wed, 4 Dec 2019 10:46:20 +0000 From: Bruce Richardson To: David Marchand Cc: "Laatz, Kevin" , dev , Thomas Monjalon , "Kinsella, Ray" , Neil Horman Message-ID: <20191204104620.GA61@bricha3-MOBL.ger.corp.intel.com> References: <20191129171024.56165-1-kevin.laatz@intel.com> <20191129210905.1865-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v3 0/7] Add ABI compatibility checks to the meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 04, 2019 at 09:47:31AM +0100, David Marchand wrote: > On Tue, Dec 3, 2019 at 4:27 PM Laatz, Kevin wrote: > > > Build targets in project: 1019 > > > WARNING: Project specifies a minimum meson_version '>= 0.47.1' but > > > uses features which were added in newer versions: > > > * 0.48.0: {'console arg in custom_target'} > > > * 0.50.0: {'install arg in configure_file'} > > > Found ninja-1.9.0 at /usr/bin/ninja > > > ninja -C /home/dmarchan/builds/build-gcc-static > > > ninja: Entering directory `/home/dmarchan/builds/build-gcc-static' > > > [48/2291] Generating librte_kvargs.abi_chk with a meson_exe.py custom command. > > > FAILED: lib/librte_kvargs.abi_chk > > > /usr/bin/meson --internal exe > > > /home/dmarchan/builds/build-gcc-static/meson-private/meson_exe_abidiff_6511538ddd95d9672028017110fa45c67f01f7be.dat > > > file /home/dmarchan/dpdk/lib/abi/librte_kvargs.dump does not exist > > > [77/2291] Compiling C object > > > 'lib/76b5a35@@rte_mbuf@sta/librte_mbuf_rte_mbuf.c.o'. > > > ninja: build stopped: subcommand failed. > > > > This is failing as the .dump files have not been created yet. They can > > be generated with devtools/gen-abi-dump.sh . This will > > generate a .dump file for each shared object in the builddir drivers and > > lib folders. > > Throwing an idea, I did not investigate. > > Could we refactor our tools/checks on the .map files to use the dump files? > We would then only maintain one file about symbols versioning. > Could be looked into, but I'd worry about the complexity of the dump files holding the whole API compared to the simpler map files which just have a simple function listing. /Bruce