From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DC5CA04B5; Wed, 4 Dec 2019 15:22:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5AE421BECF; Wed, 4 Dec 2019 15:22:37 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A66461BE84; Wed, 4 Dec 2019 15:22:35 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2019 06:22:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,277,1571727600"; d="scan'208";a="412600587" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga006.fm.intel.com with ESMTP; 04 Dec 2019 06:22:33 -0800 Date: Wed, 4 Dec 2019 22:18:21 +0800 From: Ye Xiaolong To: Luca Boccassi Cc: Ferruh Yigit , Bruce Richardson , dev@dpdk.org, stable@dpdk.org, iryzhov@nfware.com Message-ID: <20191204141821.GA26248@intel.com> References: <20191202061442.56964-1-xiaolong.ye@intel.com> <20191203155922.1565-1-xiaolong.ye@intel.com> <86964b5e0299150975d6cf7b68e5a6347cc98ef6.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86964b5e0299150975d6cf7b68e5a6347cc98ef6.camel@debian.org> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3] kernel/linux: fix kernel dir for meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/04, Luca Boccassi wrote: >On Tue, 2019-12-03 at 23:59 +0800, Xiaolong Ye wrote: >> kernel_dir option in meson build is equivalent to RTE_KERNELDIR in >> make >> system, for cross-compilation case, users would specify it as local >> kernel src dir like >> >> //target-arm_glibc/linux-arm/linux-4.19.81/ >> >> Current meson build would fail to compile kernel module if user >> specify >> kernel_dir as above, this patch fixes this issue. >> >> After this change, for normal build case, user can specify >> /lib/modules/ or /lib/modules//build >> as >> kernel_dir. For cross compilation case, user can specify any >> directory >> that contains kernel source code as the kernel_dir. >> >> Fixes: 317832f97c16 ("kernel/linux: fix modules install path") >> Cc: >> stable@dpdk.org >> >> Cc: >> iryzhov@nfware.com >> >> >> Signed-off-by: Xiaolong Ye < >> xiaolong.ye@intel.com > >The convention used by upstream and all distros is that kernel headers >are in /build. Why can't the cross compilation case also >follow this convention, rather than adding complications to the Yes, cross-compilation can follow this convention, but one common case is that users download and put kernel src (the same kernel that's running in the target machine) to one arbitrary dir, he then use this dir as kernel_dir to build kernel modules, it's extra burden for users to create extra build dir to hold the kernel headers. Thanks, Xiaolong >downstream build system? > >-- >Kind regards, >Luca Boccassi