From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73EF1A04F5; Thu, 5 Dec 2019 05:56:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD2BB1BF7F; Thu, 5 Dec 2019 05:56:35 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D000A1BF7D for ; Thu, 5 Dec 2019 05:56:33 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2019 20:56:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,279,1571727600"; d="scan'208";a="294424799" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by orsmga001.jf.intel.com with ESMTP; 04 Dec 2019 20:56:31 -0800 Date: Thu, 5 Dec 2019 12:57:00 +0800 From: Tiwei Bie To: Li Feng Cc: Maxime Coquelin , Zhihong Wang , dev@dpdk.org Message-ID: <20191205045700.GA490316@___> References: <20191202145735.9763-1-fengli@smartx.com> <20191204051320.26326-1-fengli@smartx.com> <20191204093029.GA460974@___> <20191205020703.GA481044@___> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] vhost: add config change slave msg support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Dec 05, 2019 at 12:01:55PM +0800, Li Feng wrote: > Tiwei Bie 于2019年12月5日周四 上午10:06写道： > > On Wed, Dec 04, 2019 at 05:43:50PM +0800, Li Feng wrote: > > > Hi Tiwei, > > > Thanks for your reply. > > > Yes, this new API currently is for vhost-user-blk in the SPDK project. > > > > I see. Thanks for the clarification. > > In this case, it should be declared in rte_vhost.h instead > > of vhost_user.h which is an internal header. And the symbol > > should be added to rte_vhost_version.map as well. > > > OK, one more question, should I add `__rte_experimental` tag before > the declare? Yeah. > > > > > > > There is a patch in SPDK to use this API. > > > > Could you share the link to the SPDK patch? > > > The patch is here: > https://review.gerrithub.io/c/spdk/spdk/+/476704 Thanks for the link. Will take a closer look. Thanks, Tiwei > > Thanks. > Feng Li > > > Thanks, > > Tiwei > > > > > > > > Thanks, > > > > > > Feng Li > > > > > > Tiwei Bie 于2019年12月4日周三 下午5:30写道： > > > > > > > > On Wed, Dec 04, 2019 at 01:13:20PM +0800, Li Feng wrote: > > > > > This msg is used to notify qemu that should get the config of backend. > > > > > > > > > > For example, vhost-user-blk uses this msg to notify guest os the > > > > > compacity of backend has changed. > > > > > > > > > > Signed-off-by: Li Feng > > > > > --- > > > > > v2: > > > > > * Fix a little log typo. > > > > > > > > > > lib/librte_vhost/vhost_user.c | 31 +++++++++++++++++++++++++++++++ > > > > > lib/librte_vhost/vhost_user.h | 2 ++ > > > > > 2 files changed, 33 insertions(+) > > > > > > > > > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > > > > > index 0cfb8b792..10f2e47d5 100644 > > > > > --- a/lib/librte_vhost/vhost_user.c > > > > > +++ b/lib/librte_vhost/vhost_user.c > > > > > @@ -2840,6 +2840,37 @@ vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm) > > > > > return 0; > > > > > } > > > > > > > > > > +static int > > > > > +vhost_user_slave_config_change(struct virtio_net *dev) > > > > > +{ > > > > > + int ret; > > > > > + struct VhostUserMsg msg = { > > > > > + .request.slave = VHOST_USER_SLAVE_CONFIG_CHANGE_MSG, > > > > > + .flags = VHOST_USER_VERSION, > > > > > + .size = 0, > > > > > + }; > > > > > + > > > > > + ret = send_vhost_message(dev->slave_req_fd, &msg); > > > > > + if (ret < 0) { > > > > > + RTE_LOG(ERR, VHOST_CONFIG, > > > > > + "Failed to send config change (%d)\n", > > > > > + ret); > > > > > + return ret; > > > > > + } > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +int > > > > > +rte_vhost_user_slave_config_change(int vid) > > > > > +{ > > > > > + struct virtio_net *dev; > > > > > + dev = get_device(vid); > > > > > + if (!dev) > > > > > + return -ENODEV; > > > > > + return vhost_user_slave_config_change(dev); > > > > > +} > > > > > + > > > > > static int vhost_user_slave_set_vring_host_notifier(struct virtio_net *dev, > > > > > int index, int fd, > > > > > uint64_t offset, > > > > > diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h > > > > > index 6563f7315..5c1bb2138 100644 > > > > > --- a/lib/librte_vhost/vhost_user.h > > > > > +++ b/lib/librte_vhost/vhost_user.h > > > > > @@ -62,6 +62,7 @@ typedef enum VhostUserRequest { > > > > > typedef enum VhostUserSlaveRequest { > > > > > VHOST_USER_SLAVE_NONE = 0, > > > > > VHOST_USER_SLAVE_IOTLB_MSG = 1, > > > > > + VHOST_USER_SLAVE_CONFIG_CHANGE_MSG = 2, > > > > > VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG = 3, > > > > > VHOST_USER_SLAVE_MAX > > > > > } VhostUserSlaveRequest; > > > > > @@ -158,6 +159,7 @@ typedef struct VhostUserMsg { > > > > > /* vhost_user.c */ > > > > > int vhost_user_msg_handler(int vid, int fd); > > > > > int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm); > > > > > +int rte_vhost_user_slave_config_change(int vid); > > > > > > > > This is supposed to be an API for external backends? > > > > > > > > Thanks, > > > > Tiwei > > > > > > > > > > > > > > /* socket.c */ > > > > > int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds, > > > > > -- > > > > > 2.11.0 > > > > > > > > > > > > > > > -- > > > > > The SmartX email address is only for business purpose. Any sent message > > > > > that is not related to the business is not authorized or permitted by > > > > > SmartX. > > > > > 本邮箱为北京志凌海纳科技有限公司（SmartX）工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权. > > > > > > > > > > > > > > > > -- > > > The SmartX email address is only for business purpose. Any sent message > > > that is not related to the business is not authorized or permitted by > > > SmartX. > > > 本邮箱为北京志凌海纳科技有限公司（SmartX）工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权. > > > > > > > > -- > The SmartX email address is only for business purpose. Any sent message > that is not related to the business is not authorized or permitted by > SmartX. > 本邮箱为北京志凌海纳科技有限公司（SmartX）工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权. > >