From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D015AA04F2; Fri, 6 Dec 2019 12:22:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D936D1BF8D; Fri, 6 Dec 2019 12:22:24 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 1F6781BF8B for ; Fri, 6 Dec 2019 12:22:22 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2019 03:22:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,284,1571727600"; d="scan'208";a="386482553" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by orsmga005.jf.intel.com with ESMTP; 06 Dec 2019 03:22:18 -0800 Date: Fri, 6 Dec 2019 19:22:42 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: Andrew Rybchenko , "Liang, Cunming" , Matan Azrad , "Wang, Xiao W" , Thomas Monjalon , "Wang, Zhihong" , "Yigit, Ferruh" , Shahaf Shuler , Ori Kam , "dev@dpdk.org" , Slava Ovsiienko , Asaf Penso , Olga Shern Message-ID: <20191206112242.GA19955@___> References: <20191206042745.GA706462@___> <757e8f2b-5f34-56cc-ade8-670b31e54722@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <757e8f2b-5f34-56cc-ade8-670b31e54722@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] discussion: creating a new class for vdpa driversxiao.w.wang@intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Dec 06, 2019 at 11:04:43AM +0100, Maxime Coquelin wrote: > On 12/6/19 10:05 AM, Andrew Rybchenko wrote: > > On 12/6/19 8:32 AM, Liang, Cunming wrote: > >>> -----Original Message----- > >>> From: Bie, Tiwei > >>> Sent: Friday, December 6, 2019 12:28 PM > >>> To: Matan Azrad > >>> Cc: Wang, Xiao W ; Thomas Monjalon > >>> ; maxime.coquelin@redhat.com; Wang, Zhihong > >>> ; Yigit, Ferruh ; Shahaf Shuler > >>> ; Ori Kam ; dev@dpdk.org; Slava > >>> Ovsiienko ; Asaf Penso ; Olga > >>> Shern ; Liang, Cunming > >>> Subject: Re: discussion: creating a new class for vdpa > >>> driversxiao.w.wang@intel.com > >>> > >>> On Thu, Dec 05, 2019 at 01:26:36PM +0000, Matan Azrad wrote: > >>>> Hi all > >>>> > >>>> As described in RFC “[RFC] net: new vdpa PMD for Mellanox devices”, a > >>>> new vdpa drivers is going to be added for Mellanox devices – mlx5_vdpa > >>>> > >>>> The only vdpa driver now is the IFC driver that is located in net directory. > >>>> > >>>> The IFC driver and the new mlx5_vdpa driver provide the vdpa ops and > >>>> not the eth_dev ops. > >>>> > >>>> All the others drivers in net provide the eth-dev ops. > >>>> > >>>> I suggest to create a new class for vdpa drivers, to move IFC to this > >>>> class and to add the mlx5_vdpa to this class too. > >>>> > >>>> Later, all the new drivers that implements the vdpa ops will be added > >>>> to the vdpa class. > >>> > >>> +1. Sounds like a good idea to me. > >> +1 > > > > vDPA drivers are vendor-specific and expected to talk to vendor > > NIC. I.e. there are significant chances to share code with > > network drivers (e.g. base driver). Should base driver be moved > > to drivers/common in this case or is it still allows to have > > vdpa driver in drivers/net together with ethdev driver? > > > > That's a good point. > > For example, for the Virtio vDPA driver, I placed it in th Virtio PMD > directory, so that we can re-use the Virtio-pci layer. > On the other hand, for the specific Virtio case, it may be preferable > to have a common directory. Doing that, the Virtio-pci layer could be > reused by Virtio PMD, Virtio vDPA, but also Virtio Crypto drivers. For the virtio case, I also prefer to have a common directory to allow different virtio drivers to share the virtio-pci layer. Thanks, Tiwei > > I plan to submit again my Virtio vDPA next week as it didn't make it in > v19.11. I'll wait for an agreement on this topic before proceeding. > > Thanks, > Maxime >