[dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters

[dpdk-dev] [PATCH] net/netvsc: disable before changing RSS parameters

[Stephen Hemminger]

In order to change RSS parameters, the host requires that RSS
is disable first.

Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
Cc: stable@dpdk.org
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 164e9ad174a7..575780ee5f26 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
 			hv->rss_ind[i] = reta_conf[idx].reta[shift];
 	}
 
+	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+	if (err) {
+		PMD_DRV_LOG(NOTICE,
+			"rss disable failed");
+		return err;
+	}
+
 	err = hn_rndis_conf_rss(hv, 0);
 	if (err) {
 		PMD_DRV_LOG(NOTICE,
@@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
 			return err;
 		}
 
+		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+		if (err) {
+			PMD_DRV_LOG(NOTICE,
+				"rss disable failed");
+			return err;
+		}
+
 		err = hn_rndis_conf_rss(hv, 0);
 		if (err) {
 			PMD_DRV_LOG(NOTICE,
-- 
2.20.1

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters

[Ferruh Yigit]

On 11/25/2019 5:13 PM, Stephen Hemminger wrote:
> In order to change RSS parameters, the host requires that RSS
> is disable first.
> 
> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
> Cc: stable@dpdk.org
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11

[Stephen Hemminger]

This is a resend of earlier bug fix and an additional
fix for RSS flags

Stephen Hemminger (2):
  net/netvsc: fix RSS offload flag
  net/netvsc: disable before changing RSS parameters

 drivers/net/netvsc/hn_ethdev.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

-- 
2.20.1

[dpdk-dev] [PATCH v2 1/2] net/netvsc: fix RSS offload flag

[Stephen Hemminger]

The change to add OFFLOAD_RSS_HASH broke use of netvsc PMD
with testpmd. The netvsc driver fails during configure step:

	Configuring Port 1 (socket 0)
	hn_dev_configure(): unsupported RX offload: 0x80000

Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
Cc: pbhagavatula@marvell.com
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/netvsc/hn_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 164e9ad174a7..5ef7a452cc69 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -42,7 +42,8 @@
 			    DEV_TX_OFFLOAD_VLAN_INSERT)
 
 #define HN_RX_OFFLOAD_CAPS (DEV_RX_OFFLOAD_CHECKSUM | \
-			    DEV_RX_OFFLOAD_VLAN_STRIP)
+			    DEV_RX_OFFLOAD_VLAN_STRIP | \
+			    DEV_RX_OFFLOAD_RSS_HASH)
 
 int hn_logtype_init;
 int hn_logtype_driver;
-- 
2.20.1

[dpdk-dev] [PATCH v2 2/2] net/netvsc: disable before changing RSS parameters

[Stephen Hemminger]

In order to change RSS parameters, the host requires that RSS
is disable first.

Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
Cc: stable@dpdk.org
Tested-by: Abhishek Marathe <abmarath@microsoft.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 5ef7a452cc69..159116f7f691 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -292,6 +292,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
 			hv->rss_ind[i] = reta_conf[idx].reta[shift];
 	}
 
+	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+	if (err) {
+		PMD_DRV_LOG(NOTICE,
+			"rss disable failed");
+		return err;
+	}
+
 	err = hn_rndis_conf_rss(hv, 0);
 	if (err) {
 		PMD_DRV_LOG(NOTICE,
@@ -579,6 +586,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
 			return err;
 		}
 
+		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+		if (err) {
+			PMD_DRV_LOG(NOTICE,
+				"rss disable failed");
+			return err;
+		}
+
 		err = hn_rndis_conf_rss(hv, 0);
 		if (err) {
 			PMD_DRV_LOG(NOTICE,
-- 
2.20.1

Re: [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11

[Ferruh Yigit]

On 12/6/2019 11:52 PM, Stephen Hemminger wrote:
> This is a resend of earlier bug fix and an additional
> fix for RSS flags
> 
> Stephen Hemminger (2):
>   net/netvsc: fix RSS offload flag
>   net/netvsc: disable before changing RSS parameters
> 
>  drivers/net/netvsc/hn_ethdev.c | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 


Series applied to dpdk-next-net/master, thanks.

(sign-off/tested tags for 2/2 updated as suggested,
    Signed-off-by: Donald Lee <Donald_Lee@trendmicro.com>
    Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
    Tested-by: Dexuan Cui <decui@microsoft.com>
    Tested-by: Abhishek Marathe <abmarath@microsoft.com>
)