From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5244A04F3; Sun, 8 Dec 2019 02:31:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E8BC91DBC; Sun, 8 Dec 2019 02:31:23 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5FC9423D; Sun, 8 Dec 2019 02:31:21 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2019 17:31:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,290,1571727600"; d="scan'208";a="244058114" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga002.fm.intel.com with ESMTP; 07 Dec 2019 17:31:18 -0800 Date: Sun, 8 Dec 2019 09:26:57 +0800 From: Ye Xiaolong To: Bruce Richardson Cc: Luca Boccassi , Ferruh Yigit , dev@dpdk.org, stable@dpdk.org, iryzhov@nfware.com Message-ID: <20191208012657.GA47073@intel.com> References: <20191202061442.56964-1-xiaolong.ye@intel.com> <20191203155922.1565-1-xiaolong.ye@intel.com> <86964b5e0299150975d6cf7b68e5a6347cc98ef6.camel@debian.org> <20191204141821.GA26248@intel.com> <20191204151231.GB61@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191204151231.GB61@bricha3-MOBL.ger.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3] kernel/linux: fix kernel dir for meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/04, Bruce Richardson wrote: >On Wed, Dec 04, 2019 at 10:18:21PM +0800, Ye Xiaolong wrote: >> On 12/04, Luca Boccassi wrote: >> >On Tue, 2019-12-03 at 23:59 +0800, Xiaolong Ye wrote: >> >> kernel_dir option in meson build is equivalent to RTE_KERNELDIR in >> >> make >> >> system, for cross-compilation case, users would specify it as local >> >> kernel src dir like >> >> >> >> //target-arm_glibc/linux-arm/linux-4.19.81/ >> >> >> >> Current meson build would fail to compile kernel module if user >> >> specify >> >> kernel_dir as above, this patch fixes this issue. >> >> >> >> After this change, for normal build case, user can specify >> >> /lib/modules/ or /lib/modules//build >> >> as >> >> kernel_dir. For cross compilation case, user can specify any >> >> directory >> >> that contains kernel source code as the kernel_dir. >> >> >> >> Fixes: 317832f97c16 ("kernel/linux: fix modules install path") >> >> Cc: >> >> stable@dpdk.org >> >> >> >> Cc: >> >> iryzhov@nfware.com >> >> >> >> >> >> Signed-off-by: Xiaolong Ye < >> >> xiaolong.ye@intel.com >> > >> >The convention used by upstream and all distros is that kernel headers >> >are in /build. Why can't the cross compilation case also >> >follow this convention, rather than adding complications to the >> >> Yes, cross-compilation can follow this convention, but one common case is that >> users download and put kernel src (the same kernel that's running in the target machine) >> to one arbitrary dir, he then use this dir as kernel_dir to build kernel modules, >> it's extra burden for users to create extra build dir to hold the kernel headers. >> > >As part of the build of the kernel, do you not do a "modules_install" step, >which should set up things correctly for later builds? Yes, this cmd helps. But for make build, user could specify both /lib/modules//build and any kernel src dir as RTE_KERNELDIR, I think this patch can help give user consistent experience when they migrate from make to meson build. Thanks, Xiaolong > >/Bruce