From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37B47A04F0; Tue, 10 Dec 2019 19:27:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CBD6837A2; Tue, 10 Dec 2019 19:27:43 +0100 (CET) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id B7A9A23D for ; Tue, 10 Dec 2019 19:27:42 +0100 (CET) Received: by mail-pl1-f193.google.com with SMTP id c23so198607plz.4 for ; Tue, 10 Dec 2019 10:27:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3cBBGdiIJsgYB29fxNiyMr3k2MpcjZH+7IPW80fiHFI=; b=Ncpfpdfuj+pSkW2l3yQoLiH2CP7zjTPXg5Ar0fP+7Mtb2B8LiEdPP6qoITrICj/mbb kbVR5PeUFCWTMu8puL9Iceyr60vLTf3rsSk5YMe9tWVaZ/ovrrM6XcRwsgYwM1mZwq8y mftP71LMMh9JsQzYUsTepiUfMtALeGxlnrXoGGMifc8D/WlRRYNGXBXRsIp2vjpn03bQ /V+t3z75x+vyb6L2fHmn4Trpac5wxsQTTRXYX5sXCDShS89JQIaiZl7NkzL2047D/4yE 8KTxozEUN6+G9NUwUQJZlDQNS0kTFshmmpiRNn4F5/Wf2oYDDjn3Fd8lG+ezqQJm1mpU vGcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3cBBGdiIJsgYB29fxNiyMr3k2MpcjZH+7IPW80fiHFI=; b=iYm5lIzcGRvgd0JzCSXTQUXMXJ1q+a3iEapKSMOpO0QvLpiuGJVuGb5/iRXO+hPvLh mfwo5KKnG6HjtplkXW/wp6v2uJotImbvTm8Y21h15i0VF8oOqdDge9vs+puEG3OdGYth 7p6WYMtjwmR+1uMPaS4pfA5MGDQ5GDrJX+bYu6/4d41aJzpOSHWMFD9sboAPCIbf8Kg3 qR/qvyuu9jcD1KkQ6GYl4+iYW6QGJsllpdcylSdAntQB8xRCrdBh5C9v7/i1FC+2WGEV mm2yeoT8KS02GH1JGA13BxRGCPZl6PaImmNuS6bBEkdt+dDwaGHHpWl503Y0EqbcLi+2 TFvg== X-Gm-Message-State: APjAAAW82XTw4VduOYezBWH8MLKEU9LhOg4ZUEak6lXBleKd5jsekRNS HmNp0uavomSt8J4ltF6cCi9tAQ== X-Google-Smtp-Source: APXvYqy81hvykUk2DDADhhMOx7+Se7RRmc4a7mbzeMmh8DY96QX82bBdbAK2wMcwdzlAULxqH6LZqw== X-Received: by 2002:a17:902:9a0b:: with SMTP id v11mr36522709plp.151.1576002461814; Tue, 10 Dec 2019 10:27:41 -0800 (PST) Received: from shemminger-XPS-13-9360 ([167.220.58.73]) by smtp.gmail.com with ESMTPSA id b73sm4565479pfb.72.2019.12.10.10.27.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 10:27:41 -0800 (PST) Date: Tue, 10 Dec 2019 10:27:29 -0800 From: Stephen Hemminger To: Bernard Iremonger Cc: dev@dpdk.org, beilei.xing@intel.com, qi.z.zhang@intel.com, declan.doherty@intel.com, stephen1.byrne@intel.com, konstantin.ananyev@intel.com Message-ID: <20191210102729.00360737@shemminger-XPS-13-9360> In-Reply-To: <1575982632-23059-8-git-send-email-bernard.iremonger@intel.com> References: <1575982632-23059-1-git-send-email-bernard.iremonger@intel.com> <1575982632-23059-8-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 7/9] librte_ethdev: add ESP and AH flow types to RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 10 Dec 2019 12:57:10 +0000 Bernard Iremonger wrote: > Add flow types for the following PCTYPE's in the DDP ipsec profile: > 14: IPV6 ESP > 15: IPV4 ESP > 16: IPV6 AH > 17: IPV4 AH > 18: IPV6 UDP ESP > 19: IPV4 UDP ESP > > Add the following RSS macros for IPsec: > ETH_RSS_ESP > ETH_RSS_AH > ETH_RSS_IPSEC > > Signed-off-by: Bernard Iremonger > The addition of additional flow matching is good but rte_flow still has problems. 1. There is little to know documentation about the semantics. What happens with the N*M combinations of possible flow rules, what is accepted and what does hardware do? 2. Mellanox, Intel, and Broadcom keep adding hardware match rules but there is no corresponding baseline in software. The SW flow classifier now is a trivial exercise that only matches tuples; it does not have any of the complex semantics of the rest of rte_flow. If this were a standards body, it would be rejected. Sorry to pick on this patch, but at some point the base infrastructure needs fixing before allowing more dog piling on of features.