From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E926DA04F0; Tue, 10 Dec 2019 19:31:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3E5737A2; Tue, 10 Dec 2019 19:31:46 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by dpdk.org (Postfix) with ESMTP id 73D7223D for ; Tue, 10 Dec 2019 19:31:46 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id b19so261407pfo.2 for ; Tue, 10 Dec 2019 10:31:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c0l7+qlpJaoW0Lv1L1fkOjsZg5tTG8XkF73+Yxb2e7E=; b=1oD3HcD4m61SLLBKnQGLXRO2l69yZuW6irHss8QyoeqVpd65LYn9mnd+skAMAsuC39 rpmdVETYI0B6O3xdGBBzeQ6r/fGVliw7iRHVMGSM//8cJmUwDzhTWOf1dCHjn4/V++Gj 7OK/nSJm3tbPlDvo/hrKocelOpQ9cf6Kl2uVO0gu+eTAKWRfLzAK5y+x6yQEC5dongsG zGpNoDYA0qrksNBnztlJB5TmU3D8sHfphXDxewQcMOanoMGFQ+pyvIbiLqFfg7dZM90u 8YG1Z7vuRBOYJFH0S0fwNKoaf6dyvvs7foqSYbQAs/G9jh+/7rVrZzOhF1TMXEbL8sdR VQeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c0l7+qlpJaoW0Lv1L1fkOjsZg5tTG8XkF73+Yxb2e7E=; b=pUvirH6+L7JJlCpjqNq5vJugnM62Fqx50VELVGNsDduXWwB5aq4d3nWogIqp0uWH3p Iid5FSDohP/JbAZ4F6jeVfthj1M9MaFPbSCklzpvI5I+pmuNcMfPngex+6NrVgzEYxEe Wjav5BYXYQqpMqERZ0F1UFLz9x/L2fxesnYJ847PH2OHOOej4wyedyMAau9QA14HY4tV ttGj+BgAlL1JK1VjelXwzcePRughRIinC3dOo4+e4QoaRRhOZz5VQONTvjb0nM5r1p24 XjVW/GlEiCaotaul6aK6cFtGg2Tu9u0jG16RLTmH6oZHZSV3UT0krq82xxc5b6q4P1Mp p7PA== X-Gm-Message-State: APjAAAVA8ky/qJb0gHZ1EZPh6KbNvcdFENSYx83DTGVlVb93RR8dIUcR 2/z+ofxymC9eon73z9vm9WY3dA== X-Google-Smtp-Source: APXvYqzDO9AdQX8Kyr01nCY+WnPUSJqPUUogF2eEPS/244ThrAZtE43zST1+k7rf6Jd24tMrlpN9DQ== X-Received: by 2002:aa7:9306:: with SMTP id 6mr35970709pfj.159.1576002705390; Tue, 10 Dec 2019 10:31:45 -0800 (PST) Received: from shemminger-XPS-13-9360 ([167.220.58.73]) by smtp.gmail.com with ESMTPSA id o23sm4291736pgj.90.2019.12.10.10.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 10:31:45 -0800 (PST) Date: Tue, 10 Dec 2019 10:31:33 -0800 From: Stephen Hemminger To: Andrew Rybchenko Cc: Suanming Mou , Adrien Mazarguil , John McNamara , "Marko Kovacevic" , Thomas Monjalon , Ferruh Yigit , , , , , Message-ID: <20191210103133.12ec7fe7@shemminger-XPS-13-9360> In-Reply-To: <322fb1d5-c629-5f67-59d4-c38df67f0c9b@solarflare.com> References: <1575955386-6672-1-git-send-email-suanmingm@mellanox.com> <322fb1d5-c629-5f67-59d4-c38df67f0c9b@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 10 Dec 2019 10:33:28 +0300 Andrew Rybchenko wrote: > > For some overlay network, such as VXLAN, the DSCP field in the new outer > > IP header after VXLAN decapsulation may need to be updated accordingly. > > > > This commit introduce the DSCP modify action for IPv4 and IPv6. > > > > Signed-off-by: Suanming Mou > > Acked-by: Andrew Rybchenko > > as usual it requires testpmd support and a driver which > supports it (I understand that it may be omitted in RFC). And it requires documentation and a software implementation in the flow classifier. Plus you conveniently exclude defining what happens to reserved bits. "What ever our hardware does is correct" is not a useful answer. You need to be precise and limited in what is allowed to make this usable. Sorry, to be so negative. This feature is fine in itself and a useful incremental improvement. But nobody has stepped up to address the usability of rte_flow.