From: Stephen Hemminger <stephen@networkplumber.org>
To: Suanming Mou <suanmingm@mellanox.com>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>,
Ori Kam <orika@mellanox.com>, Matan Azrad <matan@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Subject: Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action
Date: Tue, 10 Dec 2019 10:32:32 -0800 [thread overview]
Message-ID: <20191210103232.0849d74e@shemminger-XPS-13-9360> (raw)
In-Reply-To: <HE1PR05MB34846ED3E4306FDD7421C6FDCC5B0@HE1PR05MB3484.eurprd05.prod.outlook.com>
On Tue, 10 Dec 2019 08:55:40 +0000
Suanming Mou <suanmingm@mellanox.com> wrote:
> > -----Original Message-----
> > From: Andrew Rybchenko <arybchenko@solarflare.com>
> > Sent: Tuesday, December 10, 2019 3:33 PM
> > To: Suanming Mou <suanmingm@mellanox.com>; Adrien Mazarguil
> > <adrien.mazarguil@6wind.com>; John McNamara <john.mcnamara@intel.com>;
> > Marko Kovacevic <marko.kovacevic@intel.com>; Thomas Monjalon
> > <thomas@monjalon.net>; Ferruh Yigit <ferruh.yigit@intel.com>
> > Cc: dev@dpdk.org; Shahaf Shuler <shahafs@mellanox.com>; Ori Kam
> > <orika@mellanox.com>; Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> > <viacheslavo@mellanox.com>
> > Subject: Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action
> >
> > On 12/10/19 8:23 AM, Suanming Mou wrote:
> > > For some overlay network, such as VXLAN, the DSCP field in the new
> > > outer IP header after VXLAN decapsulation may need to be updated
> > accordingly.
> > >
> > > This commit introduce the DSCP modify action for IPv4 and IPv6.
> > >
> > > Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> >
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> >
> > as usual it requires testpmd support and a driver which supports it (I understand
> > that it may be omitted in RFC).
>
> Thanks. Yes, it will be added later.
Then this patch must not be applied until one or more drivers is ready to use it.
Very easy to get API and semantics wrong, until it is there.
next prev parent reply other threads:[~2019-12-10 18:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 5:23 Suanming Mou
2019-12-10 7:33 ` Andrew Rybchenko
2019-12-10 8:55 ` Suanming Mou
2019-12-10 18:32 ` Stephen Hemminger [this message]
2019-12-10 18:31 ` Stephen Hemminger
2019-12-10 19:48 ` Ori Kam
2019-12-11 1:36 ` Suanming Mou
2019-12-10 9:27 ` [dpdk-dev] [RFC v2] " Suanming Mou
2019-12-16 3:42 ` [dpdk-dev] [RFC v3 1/2] " Suanming Mou
2019-12-16 3:42 ` [dpdk-dev] [RFC v3 2/2] net/mlx5: " Suanming Mou
2019-12-16 7:49 ` [dpdk-dev] [RFC v3 1/2] ethdev: " Ori Kam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210103232.0849d74e@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=adrien.mazarguil@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=matan@mellanox.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=suanmingm@mellanox.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).