From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BF5BA04F6; Wed, 11 Dec 2019 12:11:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 828362C6A; Wed, 11 Dec 2019 12:11:54 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D98D81D9E for ; Wed, 11 Dec 2019 12:11:53 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 03:11:52 -0800 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="207644108" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Dec 2019 03:11:50 -0800 Date: Wed, 11 Dec 2019 11:11:48 +0000 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org, thomas@monjalon.net, ray.kinsella@intel.com, ferruh.yigit@intel.com Message-ID: <20191211111148.GA407@bricha3-MOBL.ger.corp.intel.com> References: <20191211102642.983579-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] build: fix soname info for 19.11 compatiblity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 11, 2019 at 11:04:01AM +0000, Luca Boccassi wrote: > On Wed, 2019-12-11 at 10:26 +0000, Bruce Richardson wrote: > > The soname for each stable ABI version should be just the ABI version > > major > > number without the minor number. Unfortunately both major and minor > > were > > used causing version 20.1 to be incompatible with 20.0. > > > > This patch fixes the issue by switching from 2-part to 3-part ABI > > version > > numbers so that we can keep 20.0 as soname and using the final digits > > to > > identify the 20.x releases which are ABI compatible. This requires > > changes > > to both make and meson builds to handle the three-digit version and > > shrink > > it to 2-digit for soname. > > > > Fixes: cba806e07d6f ("build: change ABI versioning to global") > > > > Signed-off-by: Thomas Monjalon < > > thomas@monjalon.net > > > > > Signed-off-by: Bruce Richardson < > > bruce.richardson@intel.com > > > > > --- > > > > This patch contains an alternative fix to that implied by the > > previous patches: > > http://patches.dpdk.org/patch/63726/ > > > > http://patches.dpdk.org/patch/63728/ > > > > > > --- > > ABI_VERSION | 2 +- > > drivers/meson.build | 4 ++-- > > lib/meson.build | 4 ++-- > > mk/rte.lib.mk | 5 ++++- > > 4 files changed, 9 insertions(+), 6 deletions(-) > > Acked-by: Luca Boccassi > > Thank you! I've set a reminder in my calendar for September to revert > it :-) > Lol, don't forget to put another reminder to fix things properly then too. :-) We also still need consensus in the community as to whether to take this approach or to do a re-spin of 19.11. At this point, I'm swayed by your arguments and think we should keep compatibility at the cost of a little pain and weirdness in our .so filenames. /Bruce