From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC56CA04F6; Wed, 11 Dec 2019 12:15:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8024E2C6A; Wed, 11 Dec 2019 12:15:18 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 0C71523D; Wed, 11 Dec 2019 12:15:16 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 03:15:15 -0800 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="207645390" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Dec 2019 03:15:14 -0800 Date: Wed, 11 Dec 2019 11:15:11 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: John McNamara , Marko Kovacevic , Robin Jarry , dev@dpdk.org, stable@dpdk.org Message-ID: <20191211111511.GC407@bricha3-MOBL.ger.corp.intel.com> References: <20191209210000.906000-1-thomas@monjalon.net> <20191211110140.1290875-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191211110140.1290875-1-thomas@monjalon.net> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v2] doc: fix build with python 3.8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 11, 2019 at 12:01:40PM +0100, Thomas Monjalon wrote: > After upgrading to python-3.8.0, a syntax mismatch is revealed: > > doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal. > Did you mean "!="? > if value is not '': > > Removing "is not ''" seems the right thing to do. > > A patch may also be needed in the RTD theme package: > https://github.com/readthedocs/sphinx_rtd_theme/commit/a49a812c.diff > (not included in release 0.4.3) > > Fixes: 9db3f52126fb ("doc: generate NIC overview table from ini files") > Cc: stable@dpdk.org > > Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson