DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ray.kinsella@intel.com,
	bluca@debian.org
Subject: Re: [dpdk-dev] [PATCH] build: fix soname info for 19.11 compatiblity
Date: Wed, 11 Dec 2019 13:14:20 +0000	[thread overview]
Message-ID: <20191211131420.GD407@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <269fac55-313f-1ff4-3558-f6d693cd99ff@intel.com>

On Wed, Dec 11, 2019 at 11:15:29AM +0000, Ferruh Yigit wrote:
> On 12/11/2019 10:26 AM, Bruce Richardson wrote:
> > The soname for each stable ABI version should be just the ABI version major
> > number without the minor number. Unfortunately both major and minor were
> > used causing version 20.1 to be incompatible with 20.0.
> > 
> > This patch fixes the issue by switching from 2-part to 3-part ABI version
> > numbers so that we can keep 20.0 as soname and using the final digits to
> > identify the 20.x releases which are ABI compatible. This requires changes
> > to both make and meson builds to handle the three-digit version and shrink
> > it to 2-digit for soname.
> 
> What about following, does it makes file names better?
> 
> DPDK_20.02 (ABI_20.1):
>  SONAME: .so.20.0
>  library name: .so.20.1
>  .so.20.0 --> .so.20.1
>  .so --> .so.20.1
> 
> 
> DPDK_20.05 (ABI_20.2):
>  SONAME: .so.20.0
>  library name: .so.20.2
>  .so.20.0 --> .so.20.2
>  .so --> .so.20.2
> 
> 
Personally, I really don't like having symlinks for libraries with the same
"level" of version number, i.e. while linking from 20.0 -> 20.0.1 is fine,
linking from 20.1 to 20.0 seems wrong, and would also potentially cause
issues with having 19.11 installed in parallel to another version.

/Bruce

  reply	other threads:[~2019-12-11 13:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 10:26 Bruce Richardson
2019-12-11 11:04 ` Luca Boccassi
2019-12-11 11:08   ` Thomas Monjalon
2019-12-11 11:14     ` Bruce Richardson
2019-12-11 11:19       ` Ferruh Yigit
2019-12-12 11:07         ` Ray Kinsella
2019-12-11 11:11   ` Bruce Richardson
2019-12-11 11:25     ` Ferruh Yigit
2019-12-12 11:14     ` Ray Kinsella
2019-12-12 13:58       ` Luca Boccassi
2019-12-12 14:05         ` Ray Kinsella
2019-12-12 15:08           ` Bruce Richardson
2019-12-11 11:15 ` Ferruh Yigit
2019-12-11 13:14   ` Bruce Richardson [this message]
2019-12-11 15:16 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2019-12-12  8:27   ` David Marchand
2019-12-12  8:57     ` Ferruh Yigit
2019-12-12 11:44       ` Bruce Richardson
2019-12-12 11:59         ` Bruce Richardson
2019-12-12 13:41           ` Thomas Monjalon
2019-12-12 11:58 ` [dpdk-dev] [PATCH v3] " Bruce Richardson
2019-12-12 12:30   ` Ray Kinsella
2019-12-12 13:02     ` Bruce Richardson
2019-12-12 15:25       ` Ray Kinsella
2019-12-12 15:34         ` Bruce Richardson
2019-12-12 14:45   ` Ferruh Yigit
2019-12-12 16:34   ` Ray Kinsella
2019-12-13 11:38   ` Neil Horman
2019-12-16 11:21   ` Laatz, Kevin
2019-12-19 12:42   ` David Marchand
2019-12-19 15:19     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191211131420.GD407@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=ray.kinsella@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).