From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B725EA04F6; Wed, 11 Dec 2019 17:11:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DA86B2C6A; Wed, 11 Dec 2019 17:11:24 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 53F7A1D9E for ; Wed, 11 Dec 2019 17:11:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 08:11:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="245336907" Received: from adamdybx-mobl.ger.corp.intel.com (HELO localhost.localdomain) ([10.104.14.181]) by fmsmga002.fm.intel.com with ESMTP; 11 Dec 2019 08:11:19 -0800 From: Adam Dybkowski To: dev@dpdk.org, fiona.trahe@intel.com, akhil.goyal@nxp.com, arkadiuszx.kusztal@intel.com Cc: Adam Dybkowski Date: Wed, 11 Dec 2019 17:10:14 +0100 Message-Id: <20191211161015.9845-1-adamx.dybkowski@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH 0/1] Refactor crypto unit tests. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch is a first step to refactor the overly complex symmetric crypto unit tests. It merges many separate arrays of the tests for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, sw_kasumi, sw_zuc into one big array that's then used when running unit tests on these PMDs. Individual test functions check the capabilities and execute the rest of the rest or skip (return -ENOTSUP) based on the particular test requirements - e.g. test if PMD supports ZUC algo or even a particular key length in few cases. Few edge cases required to check the PMD itself (e.g. run on QAT only, or skip on AES NI / AES GCM). It's the first step of bigger refactoring. Maintainers of other PMDs are encouraged to add their PMD unit tests also into this big central array and remove individual test macro arrays. This patch doesn't address next refactoring steps to be done in the future: geting rid of many small (usually 1-2 line) test functions, created separately for every test case; and simplifying many bigger functions that currently do similar things but work on different test vector structures. Adam Dybkowski (1): test/crypto: refactor unit tests into one combined array app/test/test_cryptodev.c | 16113 +++++++++---------- app/test/test_cryptodev_blockcipher.c | 2 +- app/test/test_cryptodev_des_test_vectors.h | 6 +- 3 files changed, 7430 insertions(+), 8691 deletions(-) -- 2.17.1