* [dpdk-dev] [PATCH] net/iavf: fix Rx total stats
@ 2019-12-12 13:49 Jiaqi Min
2019-12-13 1:23 ` [dpdk-dev] [PATCH v2] " Jiaqi Min
0 siblings, 1 reply; 4+ messages in thread
From: Jiaqi Min @ 2019-12-12 13:49 UTC (permalink / raw)
To: dev; +Cc: Jingjing Wu, Wenzhuo Lu, Qiming Yang, Jiaqi Min, stable
Rx total statistics error when packets above
the jumbo frame. The patch fixed the issue.
Fixes: f4a41a6953af ("net/avf: support stats")
Cc: stable@dpdk.org
Signed-off-by: Jiaqi Min <jiaqix.min@intel.com>
---
drivers/net/iavf/iavf_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index a39ba1466..867843205 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1068,7 +1068,7 @@ iavf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
if (ret == 0) {
iavf_update_stats(vsi, pstats);
stats->ipackets = pstats->rx_unicast + pstats->rx_multicast +
- pstats->rx_broadcast;
+ pstats->rx_broadcast - pstats->rx_discards;
stats->opackets = pstats->tx_broadcast + pstats->tx_multicast +
pstats->tx_unicast;
stats->imissed = pstats->rx_discards;
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v2] net/iavf: fix Rx total stats
2019-12-12 13:49 [dpdk-dev] [PATCH] net/iavf: fix Rx total stats Jiaqi Min
@ 2019-12-13 1:23 ` Jiaqi Min
2019-12-13 7:16 ` Wu, Jingjing
0 siblings, 1 reply; 4+ messages in thread
From: Jiaqi Min @ 2019-12-13 1:23 UTC (permalink / raw)
To: dev; +Cc: Jingjing Wu, Qiming Yang, Jiaqi Min, stable
Rx total stats is the total number of successfully received packets,
so exclude the number of rx_discards for Rx total stats.
Fixes: f4a41a6953af ("net/avf: support stats")
Cc: stable@dpdk.org
Signed-off-by: Jiaqi Min <jiaqix.min@intel.com>
---
v2:
* Changed commit message.
---
drivers/net/iavf/iavf_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index a39ba1466..f544303c0 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1068,7 +1068,7 @@ iavf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
if (ret == 0) {
iavf_update_stats(vsi, pstats);
stats->ipackets = pstats->rx_unicast + pstats->rx_multicast +
- pstats->rx_broadcast;
+ pstats->rx_broadcast - pstats->rx_discards;
stats->opackets = pstats->tx_broadcast + pstats->tx_multicast +
pstats->tx_unicast;
stats->imissed = pstats->rx_discards;
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/iavf: fix Rx total stats
2019-12-13 1:23 ` [dpdk-dev] [PATCH v2] " Jiaqi Min
@ 2019-12-13 7:16 ` Wu, Jingjing
2019-12-13 7:57 ` Ye Xiaolong
0 siblings, 1 reply; 4+ messages in thread
From: Wu, Jingjing @ 2019-12-13 7:16 UTC (permalink / raw)
To: Min, JiaqiX, dev; +Cc: Yang, Qiming, stable
> -----Original Message-----
> From: Min, JiaqiX <jiaqix.min@intel.com>
> Sent: Friday, December 13, 2019 9:23 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Min, JiaqiX
> <jiaqix.min@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/iavf: fix Rx total stats
>
> Rx total stats is the total number of successfully received packets,
> so exclude the number of rx_discards for Rx total stats.
>
> Fixes: f4a41a6953af ("net/avf: support stats")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jiaqi Min <jiaqix.min@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/iavf: fix Rx total stats
2019-12-13 7:16 ` Wu, Jingjing
@ 2019-12-13 7:57 ` Ye Xiaolong
0 siblings, 0 replies; 4+ messages in thread
From: Ye Xiaolong @ 2019-12-13 7:57 UTC (permalink / raw)
To: Wu, Jingjing; +Cc: Min, JiaqiX, dev, Yang, Qiming, stable
On 12/13, Wu, Jingjing wrote:
>
>
>> -----Original Message-----
>> From: Min, JiaqiX <jiaqix.min@intel.com>
>> Sent: Friday, December 13, 2019 9:23 AM
>> To: dev@dpdk.org
>> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Min, JiaqiX
>> <jiaqix.min@intel.com>; stable@dpdk.org
>> Subject: [PATCH v2] net/iavf: fix Rx total stats
>>
>> Rx total stats is the total number of successfully received packets,
>> so exclude the number of rx_discards for Rx total stats.
>>
>> Fixes: f4a41a6953af ("net/avf: support stats")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jiaqi Min <jiaqix.min@intel.com>
>Acked-by: Jingjing Wu <jingjing.wu@intel.com>
>
>
Applied to dpdk-next-net-intel, Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-13 8:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 13:49 [dpdk-dev] [PATCH] net/iavf: fix Rx total stats Jiaqi Min
2019-12-13 1:23 ` [dpdk-dev] [PATCH v2] " Jiaqi Min
2019-12-13 7:16 ` Wu, Jingjing
2019-12-13 7:57 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).