From: Stephen Hemminger <stephen@networkplumber.org>
To: Michal Krawczyk <mk@semihalf.com>
Cc: dev@dpdk.org, gtzalik@amazon.com, mw@semihalf.com,
matua@amazon.com, mba@semihalf.com, igorch@amazon.com
Subject: Re: [dpdk-dev] [PATCH 1/2] net/ena: upgrade HAL for new HW features
Date: Fri, 13 Dec 2019 08:34:20 -0800 [thread overview]
Message-ID: <20191213083420.31f2b7c8@hermes.lan> (raw)
In-Reply-To: <20191213133216.23572-2-mk@semihalf.com>
On Fri, 13 Dec 2019 14:32:15 +0100
Michal Krawczyk <mk@semihalf.com> wrote:
> This version of the HAL allows to use the latest HW features, like
> rx offsets.
>
> Driver was adjusted to the new version to fix the build.
>
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> Signed-off-by: Maciej Bielski <mba@semihalf.com>
You are mixing multiple changes into one patch.
This makes it harder to review (find the real bits) and also
harder for bisection.
It makes sense to fix whitespace and related stuff in one
patch if you are fixing one function and the nearby code
already needed work. But please avoid larger scale change
put together.
In your patch I see:
- remove unnecessary whitespace
- drop unnecessary inline
- add missing newline in log messages
- check for NULL pointer
If possible could you preserve the per-commit updates for base
code, rather than one lump diff.
next prev parent reply other threads:[~2019-12-13 16:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 13:32 [dpdk-dev] [PATCH 0/2] net/ena: add support for Rx offsets Michal Krawczyk
2019-12-13 13:32 ` [dpdk-dev] [PATCH 1/2] net/ena: upgrade HAL for new HW features Michal Krawczyk
2019-12-13 16:34 ` Stephen Hemminger [this message]
2019-12-13 20:01 ` Michał Krawczyk
2020-01-09 14:27 ` Ferruh Yigit
2020-01-09 15:26 ` Michał Krawczyk
2020-01-09 14:30 ` Ferruh Yigit
2020-01-09 15:39 ` [dpdk-dev] [PATCH v2 " Michal Krawczyk
2020-01-10 9:04 ` Ferruh Yigit
2020-01-10 9:39 ` Michał Krawczyk
2020-01-10 10:32 ` Ferruh Yigit
2019-12-13 13:32 ` [dpdk-dev] [PATCH 2/2] net/ena: add support for RX_OFFSET feature Michal Krawczyk
2020-01-10 10:32 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213083420.31f2b7c8@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=matua@amazon.com \
--cc=mba@semihalf.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).